PluginDetails: Make plugin details page look good in topnav (#55571)

* PluginDetails: Make plugin details page look good in topnav

* Minor style tweak aligning things

* minor refactoring where I moved the logic to decide the default tab into its own hook.

* refactor(plugindetails): first pass at using navmodel for usePluginDetailsTabs hook

* refactor(plugindetails): move "reset page when uninstalling plugin" to installcontrols

this prevents a user from seeing a blank page if they uninstall an app plugin whilst viewing a
config page

* refactor(plugindetails): remove usage of toIconName and reduce nested if

* Trying to fix tests

* minor fix

* test(plugindetails): update selectors causing failing tests

* chore(plugindetails): remove commented out test code

* test(plugindetails): clean up - remove unnecesary usage of waitFor

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>

This commit is contained in:

Torkel Ödegaard

2022-09-26 15:04:07 +02:00

committed by

GitHub

co-authored by

Marcus Andersson

Jack Westbrook

parent 1a830e6f45

commit 018733dd24

14 changed files with 233 additions and 273 deletions

									
										packages/grafana-data/src/types/navModel.ts
									
		+2
		
												View File
												
				@@ -36,6 +36,8 @@ export interface NavModelItem extends NavLinkDTO {

				  highlightId?: string;

				  tabSuffix?: ComponentType<{ className?: string }>;

				  hideFromBreadcrumbs?: boolean;

				  /** To render custom things between title and child tabs */

				  headerExtra?: ComponentType;

				}

				export enum NavSection {