PluginDetails: Make plugin details page look good in topnav (#55571)

* PluginDetails: Make plugin details page look good in topnav

* Minor style tweak aligning things

* minor refactoring where I moved the logic to decide the default tab into its own hook.

* refactor(plugindetails): first pass at using navmodel for usePluginDetailsTabs hook

* refactor(plugindetails): move "reset page when uninstalling plugin" to installcontrols

this prevents a user from seeing a blank page if they uninstall an app plugin whilst viewing a
config page

* refactor(plugindetails): remove usage of toIconName and reduce nested if

* Trying to fix tests

* minor fix

* test(plugindetails): update selectors causing failing tests

* chore(plugindetails): remove commented out test code

* test(plugindetails): clean up - remove unnecesary usage of waitFor

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>

pkg/build/packaging/grafana.go

@@ -1033,7 +1033,7 @@ func createZip(srcDir, version, variantStr, sfx, grafanaDir string) error {
 	return nil
 }
 
-//nolint
+// nolint
 func createTarball(srcDir, version, variantStr, sfx, grafanaDir string) error {
 	fpath := filepath.Join(grafanaDir, "dist", fmt.Sprintf("grafana%s-%s.%s.tar.gz", sfx, version, variantStr))
 	//nolint:gosec

pkg/services/ngalert/eval/evaluator_mock.go

@@ -51,10 +51,10 @@ type FakeEvaluator_ConditionEval_Call struct {
 }
 
 // ConditionEval is a helper method to define mock.On call
-//  - ctx context.Context
-//  - _a1 *user.SignedInUser
-//  - condition models.Condition
-//  - now time.Time
+//   - ctx context.Context
+//   - _a1 *user.SignedInUser
+//   - condition models.Condition
+//   - now time.Time
 func (_e *FakeEvaluator_Expecter) ConditionEval(ctx interface{}, _a1 interface{}, condition interface{}, now interface{}) *FakeEvaluator_ConditionEval_Call {
 	return &FakeEvaluator_ConditionEval_Call{Call: _e.mock.On("ConditionEval", ctx, _a1, condition, now)}
 }
@@ -100,10 +100,10 @@ type FakeEvaluator_QueriesAndExpressionsEval_Call struct {
 }
 
 // QueriesAndExpressionsEval is a helper method to define mock.On call
-//  - ctx context.Context
-//  - _a1 *user.SignedInUser
-//  - data []models.AlertQuery
-//  - now time.Time
+//   - ctx context.Context
+//   - _a1 *user.SignedInUser
+//   - data []models.AlertQuery
+//   - now time.Time
 func (_e *FakeEvaluator_Expecter) QueriesAndExpressionsEval(ctx interface{}, _a1 interface{}, data interface{}, now interface{}) *FakeEvaluator_QueriesAndExpressionsEval_Call {
 	return &FakeEvaluator_QueriesAndExpressionsEval_Call{Call: _e.mock.On("QueriesAndExpressionsEval", ctx, _a1, data, now)}
 }
@@ -140,9 +140,9 @@ type FakeEvaluator_Validate_Call struct {
 }
 
 // Validate is a helper method to define mock.On call
-//  - ctx context.Context
-//  - _a1 *user.SignedInUser
-//  - condition models.Condition
+//   - ctx context.Context
+//   - _a1 *user.SignedInUser
+//   - condition models.Condition
 func (_e *FakeEvaluator_Expecter) Validate(ctx interface{}, _a1 interface{}, condition interface{}) *FakeEvaluator_Validate_Call {
 	return &FakeEvaluator_Validate_Call{Call: _e.mock.On("Validate", ctx, _a1, condition)}
 }