public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the need for plugins to implement AdmissionHandler for v0alpha1 (#93272)

Browse Source
This commit is contained in:
Andres Martinez Gotor
2024-09-13 09:08:26 +02:00
committed by GitHub
parent d60a28b3c8
commit 01a4e6b9af
3 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/datasources/service/datasource.go
+8
View File
@@ -367,6 +367,10 @@ func (s *Service) prepareInstanceSettings(ctx context.Context, settings *backend
rsp, err := s.pluginClient.ValidateAdmission(ctx, req)
if err != nil {
if errors.Is(err, plugins.ErrMethodNotImplemented) {
if settings.APIVersion == "v0alpha1" {
// For v0alpha1 we don't require plugins to implement ValidateAdmission
return settings, nil
}
return nil, errutil.Internal("plugin.unimplemented").
Errorf("plugin (%s) with apiVersion=%s must implement ValidateAdmission", p.ID, settings.APIVersion)
}
@@ -388,6 +392,10 @@ func (s *Service) prepareInstanceSettings(ctx context.Context, settings *backend
rsp, err := s.pluginClient.MutateAdmission(ctx, req)
if err != nil {
if errors.Is(err, plugins.ErrMethodNotImplemented) {
if settings.APIVersion == "v0alpha1" {
// For v0alpha1 we don't require plugins to implement MutateAdmission
return settings, nil
}
return nil, errutil.Internal("plugin.unimplemented").
Errorf("plugin (%s) with apiVersion=%s must implement MutateAdmission", p.ID, settings.APIVersion)
}