Remove the need for plugins to implement AdmissionHandler for v0alpha1 (#93272)

This commit is contained in:
Andres Martinez Gotor
2024-09-13 09:08:26 +02:00
committed by GitHub
parent d60a28b3c8
commit 01a4e6b9af
3 changed files with 31 additions and 3 deletions
@@ -135,13 +135,35 @@ func TestService_AddDataSource(t *testing.T) {
OrgID: 1,
Type: "test", // required to validate apiserver
Name: "test",
APIVersion: "v0alpha1",
APIVersion: "v1",
}
_, err := dsService.AddDataSource(context.Background(), cmd)
require.NoError(t, err)
require.True(t, validateExecuted)
})
t.Run("should ignore if AdmissionHandler is not implemented for v0alpha1", func(t *testing.T) {
dsService := initDSService(t)
dsService.pluginStore = &pluginstore.FakePluginStore{
PluginList: []pluginstore.Plugin{{
JSONData: plugins.JSONData{
ID: "test",
Type: plugins.TypeDataSource,
Name: "test",
},
}},
}
dsService.pluginClient = &pluginfakes.FakePluginClient{}
cmd := &datasources.AddDataSourceCommand{
OrgID: 1,
Type: "test", // required to validate apiserver
Name: "test",
APIVersion: "v0alpha1",
}
_, err := dsService.AddDataSource(context.Background(), cmd)
require.NoError(t, err)
})
t.Run("should fail at validation", func(t *testing.T) {
dsService := initDSService(t)
dsService.pluginStore = &pluginstore.FakePluginStore{