Instrument tracing across accesscontrol (#91864)

Instrument tracing across accesscontrol 

---------

Co-authored-by: Dave Henderson <dave.henderson@grafana.com>

pkg/services/accesscontrol/ossaccesscontrol/dashboard.go

@@ -113,6 +113,9 @@ func ProvideDashboardPermissions(
 		Resource:          "dashboards",
 		ResourceAttribute: "uid",
 		ResourceValidator: func(ctx context.Context, orgID int64, resourceID string) error {
+			ctx, span := tracer.Start(ctx, "accesscontrol.ossaccesscontrol.ProvideDashboardPermissions.ResourceValidator")
+			defer span.End()
+
 			dashboard, err := getDashboard(ctx, orgID, resourceID)
 			if err != nil {
 				return err

pkg/services/accesscontrol/ossaccesscontrol/datasource.go

@@ -10,8 +10,11 @@ import (
 	"github.com/grafana/grafana/pkg/services/datasources"
 	"github.com/grafana/grafana/pkg/services/featuremgmt"
 	"github.com/grafana/grafana/pkg/setting"
+	"go.opentelemetry.io/otel"
 )
 
+var tracer = otel.Tracer("github.com/grafana/grafana/pkg/accesscontrol/ossaccesscontrol")
+
 // DatasourceQueryActions contains permissions to read information
 // about a data source and submit arbitrary queries to it.
 var DatasourceQueryActions = []string{
@@ -51,6 +54,9 @@ func (e DatasourcePermissionsService) SetBuiltInRolePermission(ctx context.Conte
 // if an OSS/unlicensed instance is upgraded to Enterprise/licensed.
 // https://github.com/grafana/identity-access-team/issues/672
 func (e DatasourcePermissionsService) SetPermissions(ctx context.Context, orgID int64, resourceID string, commands ...accesscontrol.SetResourcePermissionCommand) ([]accesscontrol.ResourcePermission, error) {
+	ctx, span := tracer.Start(ctx, "accesscontrol.ossaccesscontrol.SetPermissions")
+	defer span.End()
+
 	dbCommands := make([]resourcepermissions.SetResourcePermissionsCommand, 0, len(commands))
 	for _, cmd := range commands {
 		// Only set query permissions for built-in roles; do not set permissions for data sources with * as UID, as this would grant wildcard permissions
@@ -75,6 +81,9 @@ func (e DatasourcePermissionsService) SetPermissions(ctx context.Context, orgID
 }
 
 func (e DatasourcePermissionsService) DeleteResourcePermissions(ctx context.Context, orgID int64, resourceID string) error {
+	ctx, span := tracer.Start(ctx, "accesscontrol.ossaccesscontrol.DeleteResourcePermissions")
+	defer span.End()
+
 	return e.store.DeleteResourcePermissions(ctx, orgID, &resourcepermissions.DeleteResourcePermissionsCmd{
 		Resource:          datasources.ScopeRoot,
 		ResourceAttribute: "uid",

pkg/services/accesscontrol/ossaccesscontrol/folder.go

@@ -95,6 +95,9 @@ func ProvideFolderPermissions(
 		Resource:          "folders",
 		ResourceAttribute: "uid",
 		ResourceValidator: func(ctx context.Context, orgID int64, resourceID string) error {
+			ctx, span := tracer.Start(ctx, "accesscontrol.ossaccesscontrol.ProvideFolderPermissions.ResourceValidator")
+			defer span.End()
+
 			query := &dashboards.GetDashboardQuery{UID: resourceID, OrgID: orgID}
 			queryResult, err := dashboardStore.GetDashboard(ctx, query)
 			if err != nil {

pkg/services/accesscontrol/ossaccesscontrol/service_account.go

@@ -44,6 +44,9 @@ func ProvideServiceAccountPermissions(
 		Resource:          "serviceaccounts",
 		ResourceAttribute: "id",
 		ResourceValidator: func(ctx context.Context, orgID int64, resourceID string) error {
+			ctx, span := tracer.Start(ctx, "accesscontrol.ossaccesscontrol.ProvideServiceAccountPermissions.ResourceValidator")
+			defer span.End()
+
 			id, err := strconv.ParseInt(resourceID, 10, 64)
 			if err != nil {
 				return err

pkg/services/accesscontrol/ossaccesscontrol/team.go

@@ -46,12 +46,15 @@ func ProvideTeamPermissions(
 		ResourceAttribute: "id",
 		OnlyManaged:       true,
 		ResourceValidator: func(ctx context.Context, orgID int64, resourceID string) error {
+			ctx, span := tracer.Start(ctx, "accesscontrol.ossaccesscontrol.ProvideTeamerPermissions.ResourceValidator")
+			defer span.End()
+
 			id, err := strconv.ParseInt(resourceID, 10, 64)
 			if err != nil {
 				return err
 			}
 
-			_, err = teamService.GetTeamByID(context.Background(), &team.GetTeamByIDQuery{
+			_, err = teamService.GetTeamByID(ctx, &team.GetTeamByIDQuery{
 				OrgID: orgID,
 				ID:    id,
 			})