Storage: Use Error property for error handling rather than Status (#90416)

replace status with error
This commit is contained in:
Ryan McKinley
2024-07-16 07:43:15 -07:00
committed by GitHub
parent 93221f12da
commit 030188831d
6 changed files with 792 additions and 408 deletions
+6 -6
View File
@@ -97,13 +97,13 @@ func TestSimpleServer(t *testing.T) {
Key: key,
})
require.NoError(t, err)
require.Nil(t, created.Status)
require.Nil(t, created.Error)
require.True(t, created.ResourceVersion > 0)
// The key does not include resource version
found, err := server.Read(ctx, &ReadRequest{Key: key})
require.NoError(t, err)
require.Nil(t, found.Status)
require.Nil(t, found.Error)
require.Equal(t, created.ResourceVersion, found.ResourceVersion)
// Now update the value
@@ -125,13 +125,13 @@ func TestSimpleServer(t *testing.T) {
Value: raw,
ResourceVersion: created.ResourceVersion})
require.NoError(t, err)
require.Nil(t, updated.Status)
require.Nil(t, updated.Error)
require.True(t, updated.ResourceVersion > created.ResourceVersion)
// We should still get the latest
found, err = server.Read(ctx, &ReadRequest{Key: key})
require.NoError(t, err)
require.Nil(t, found.Status)
require.Nil(t, found.Error)
require.Equal(t, updated.ResourceVersion, found.ResourceVersion)
all, err = server.List(ctx, &ListRequest{Options: &ListOptions{
@@ -151,8 +151,8 @@ func TestSimpleServer(t *testing.T) {
// We should get not found status when trying to read the latest value
found, err = server.Read(ctx, &ReadRequest{Key: key})
require.NoError(t, err)
require.NotNil(t, found.Status)
require.Equal(t, int32(404), found.Status.Code)
require.NotNil(t, found.Error)
require.Equal(t, int32(404), found.Error.Code)
// And the deleted value should not be in the results
all, err = server.List(ctx, &ListRequest{Options: &ListOptions{