From 4d75f28831bed1729898cea5fcf045d19ba3f5af Mon Sep 17 00:00:00 2001 From: Taewoo Kim Date: Mon, 8 May 2023 16:08:54 -0400 Subject: [PATCH 1/3] fix tooltip text --- .../datasources/components/useDataSourceInfo.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/public/app/features/datasources/components/useDataSourceInfo.tsx b/public/app/features/datasources/components/useDataSourceInfo.tsx index 3f7fc8fb588..5c3764ffc8f 100644 --- a/public/app/features/datasources/components/useDataSourceInfo.tsx +++ b/public/app/features/datasources/components/useDataSourceInfo.tsx @@ -21,11 +21,11 @@ export const useDataSourceInfo = (dataSourceInfo: DataSourceInfo): PageInfoItem[ info.push({ label: ( - - <> - Default - - + +
+ Deault + +
), value: ( From cee795efff54c015f566176d7c3a1a6420623f7d Mon Sep 17 00:00:00 2001 From: Taewoo Kim Date: Mon, 8 May 2023 16:11:44 -0400 Subject: [PATCH 2/3] fix navId for connections datasources edit page --- public/app/features/connections/pages/EditDataSourcePage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/app/features/connections/pages/EditDataSourcePage.tsx b/public/app/features/connections/pages/EditDataSourcePage.tsx index 9457f2acb0a..ac8e2596501 100644 --- a/public/app/features/connections/pages/EditDataSourcePage.tsx +++ b/public/app/features/connections/pages/EditDataSourcePage.tsx @@ -9,5 +9,5 @@ export function EditDataSourcePage() { const params = new URLSearchParams(location.search); const pageId = params.get('page'); - return ; + return ; } From 1a15395d46fbf575e725ca2e5ff4543d1b513ead Mon Sep 17 00:00:00 2001 From: Taewoo Kim Date: Mon, 8 May 2023 16:25:38 -0400 Subject: [PATCH 3/3] fix e2e selector: change autoSizeInput to Input --- .../grafana-e2e-selectors/src/selectors/pages.ts | 2 +- .../datasources/components/EditDataSourceTitle.tsx | 13 ++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/packages/grafana-e2e-selectors/src/selectors/pages.ts b/packages/grafana-e2e-selectors/src/selectors/pages.ts index 52b76aad6c7..d6326eb1efc 100644 --- a/packages/grafana-e2e-selectors/src/selectors/pages.ts +++ b/packages/grafana-e2e-selectors/src/selectors/pages.ts @@ -17,7 +17,7 @@ export const Pages = { url: '/', }, DataSource: { - name: 'Data source settings page name input field', + name: 'data-testid Data source settings page name input field', nameEditIcon: 'data-testid Data source settings page name edit icon button', delete: 'Data source settings page Delete button', readOnly: 'Data source settings page read only message', diff --git a/public/app/features/datasources/components/EditDataSourceTitle.tsx b/public/app/features/datasources/components/EditDataSourceTitle.tsx index 640bf0a85f6..365f418b7cd 100644 --- a/public/app/features/datasources/components/EditDataSourceTitle.tsx +++ b/public/app/features/datasources/components/EditDataSourceTitle.tsx @@ -3,7 +3,7 @@ import React, { useEffect, useState } from 'react'; import { DataSourceSettings, GrafanaTheme2 } from '@grafana/data'; import { selectors } from '@grafana/e2e-selectors'; -import { IconButton, AutoSizeInput, useStyles2 } from '@grafana/ui'; +import { IconButton, useStyles2, Input } from '@grafana/ui'; interface Props { dataSource: DataSourceSettings; @@ -60,18 +60,17 @@ export function EditDataSourceTitle({ dataSource, title, readOnly, onUpdate }: P ) : (
- ) => handleNameChange(evt.currentTarget.value)} - minWidth={40} - maxWidth={80} + onChange={(evt: React.FormEvent) => setName(evt.currentTarget.value)} + onBlur={(evt: React.FormEvent) => handleNameChange(evt.currentTarget.value)} required data-testid={selectors.pages.DataSource.name} autoFocus={isNameEditable} - > + >
)}