From 03b323cb61c5c8bb4b8c8faf9884e4744766dedb Mon Sep 17 00:00:00 2001 From: Matias Chomicki Date: Fri, 22 Nov 2024 11:12:59 +0000 Subject: [PATCH] DataSourceWithSupplementaryQueriesSupport: remove @internal (#96901) * DataSourceWithSupplementaryQueriesSupport: no longer internal * Loki: update comments --- packages/grafana-data/src/types/logs.ts | 1 - public/app/plugins/datasource/loki/datasource.ts | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/grafana-data/src/types/logs.ts b/packages/grafana-data/src/types/logs.ts index 2d363a63f7e..86df7bde61f 100644 --- a/packages/grafana-data/src/types/logs.ts +++ b/packages/grafana-data/src/types/logs.ts @@ -235,7 +235,6 @@ export type LogsVolumeCustomMetaData = { * Data sources that support supplementary queries in Explore. * This will enable users to see additional data when running original queries. * Supported supplementary queries are defined in SupplementaryQueryType enum. - * @internal */ export interface DataSourceWithSupplementaryQueriesSupport { /** diff --git a/public/app/plugins/datasource/loki/datasource.ts b/public/app/plugins/datasource/loki/datasource.ts index e146973ccf7..dc52aca0a11 100644 --- a/public/app/plugins/datasource/loki/datasource.ts +++ b/public/app/plugins/datasource/loki/datasource.ts @@ -254,7 +254,7 @@ export class LokiDatasource /** * Private method used in the `getDataProvider` for DataSourceWithSupplementaryQueriesSupport, specifically for Logs volume queries. - * @returns An Observable of DataQueryResponse or undefined if no suitable queries are found. + * @returns A DataQueryRequest or undefined if no suitable queries are found. */ private getLogsVolumeDataProvider( request: DataQueryRequest, @@ -274,7 +274,7 @@ export class LokiDatasource /** * Private method used in the `getDataProvider` for DataSourceWithSupplementaryQueriesSupport, specifically for Logs sample queries. - * @returns An Observable of DataQueryResponse or undefined if no suitable queries are found. + * @returns A DataQueryRequest or undefined if no suitable queries are found. */ private getLogsSampleDataProvider( request: DataQueryRequest,