From 03f7fd0527b07db4bea8dc2e4e18d0d169ea9cb6 Mon Sep 17 00:00:00 2001
From: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Date: Wed, 17 Jun 2020 10:04:38 +0200
Subject: [PATCH] Elasticsearch: Support using a variable for histogram and
 terms min doc count (#25392)

Support using a variable for histogram and terms min doc count.
This is an addition to #21064.

Ref #21052
Ref #21064
---
 .../elasticsearch/partials/bucket_agg.html    |  4 +-
 .../datasource/elasticsearch/query_builder.ts |  4 ++
 .../elasticsearch/specs/query_builder.test.ts | 44 +++++++++++++++++++
 3 files changed, 50 insertions(+), 2 deletions(-)

diff --git a/public/app/plugins/datasource/elasticsearch/partials/bucket_agg.html b/public/app/plugins/datasource/elasticsearch/partials/bucket_agg.html
index cca50a6fbfb..bf23328e623 100644
--- a/public/app/plugins/datasource/elasticsearch/partials/bucket_agg.html
+++ b/public/app/plugins/datasource/elasticsearch/partials/bucket_agg.html
@@ -116,7 +116,7 @@
     <div class="gf-form offset-width-7">
       <label class="gf-form-label width-10">Min Doc Count</label>
       <input
-        type="number"
+        type="text"
         class="gf-form-input max-width-12"
         ng-model="agg.settings.min_doc_count"
         ng-blur="onChangeInternal()"
@@ -153,7 +153,7 @@
     <div class="gf-form offset-width-7">
       <label class="gf-form-label width-10">Min Doc Count</label>
       <input
-        type="number"
+        type="text"
         class="gf-form-input max-width-12"
         ng-model="agg.settings.min_doc_count"
         ng-blur="onChangeInternal()"
diff --git a/public/app/plugins/datasource/elasticsearch/query_builder.ts b/public/app/plugins/datasource/elasticsearch/query_builder.ts
index 42be4356561..f26454f0390 100644
--- a/public/app/plugins/datasource/elasticsearch/query_builder.ts
+++ b/public/app/plugins/datasource/elasticsearch/query_builder.ts
@@ -55,6 +55,10 @@ export class ElasticQueryBuilder {
 
     if (aggDef.settings.min_doc_count !== void 0) {
       queryNode.terms.min_doc_count = parseInt(aggDef.settings.min_doc_count, 10);
+
+      if (isNaN(queryNode.terms.min_doc_count)) {
+        queryNode.terms.min_doc_count = aggDef.settings.min_doc_count;
+      }
     }
 
     if (aggDef.settings.missing) {
diff --git a/public/app/plugins/datasource/elasticsearch/specs/query_builder.test.ts b/public/app/plugins/datasource/elasticsearch/specs/query_builder.test.ts
index ff016717a28..162a2112eea 100644
--- a/public/app/plugins/datasource/elasticsearch/specs/query_builder.test.ts
+++ b/public/app/plugins/datasource/elasticsearch/specs/query_builder.test.ts
@@ -103,6 +103,50 @@ describe('ElasticQueryBuilder', () => {
         expect(secondLevel.aggs['5'].avg.field).toBe('@value');
       });
 
+      it('with term agg and valid min_doc_count', () => {
+        const query = builder.build(
+          {
+            metrics: [{ type: 'count', id: '1' }],
+            bucketAggs: [
+              {
+                type: 'terms',
+                field: '@host',
+                settings: { min_doc_count: 1 },
+                id: '2',
+              },
+              { type: 'date_histogram', field: '@timestamp', id: '3' },
+            ],
+          },
+          100,
+          '1000'
+        );
+
+        const firstLevel = query.aggs['2'];
+        expect(firstLevel.terms.min_doc_count).toBe(1);
+      });
+
+      it('with term agg and variable as min_doc_count', () => {
+        const query = builder.build(
+          {
+            metrics: [{ type: 'count', id: '1' }],
+            bucketAggs: [
+              {
+                type: 'terms',
+                field: '@host',
+                settings: { min_doc_count: '$min_doc_count' },
+                id: '2',
+              },
+              { type: 'date_histogram', field: '@timestamp', id: '3' },
+            ],
+          },
+          100,
+          '1000'
+        );
+
+        const firstLevel = query.aggs['2'];
+        expect(firstLevel.terms.min_doc_count).toBe('$min_doc_count');
+      });
+
       it('with metric percentiles', () => {
         const query = builder.build(
           {