From 04900c63f05af417685c30f2ccfa02bee6ba5961 Mon Sep 17 00:00:00 2001
From: "Grot (@grafanabot)" <43478413+grafanabot@users.noreply.github.com>
Date: Wed, 22 Sep 2021 07:46:22 -0400
Subject: [PATCH] Plugins Catalog: add a few more tests (#39433) (#39470)

* refactor(Plugins/Admin): add an extra line-break between tests

* test(Plugins/Admin): add a couple of more tests for Plugin Details

* fix(Plugins/Admin): fix accidental linting issue

(cherry picked from commit 660afc62795664f9fc2687dd214bf104823a9c96)

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
---
 .../plugins/admin/pages/Browse.test.tsx       |  1 +
 .../admin/pages/PluginDetails.test.tsx        | 47 ++++++++++++++++++-
 2 files changed, 47 insertions(+), 1 deletion(-)

diff --git a/public/app/features/plugins/admin/pages/Browse.test.tsx b/public/app/features/plugins/admin/pages/Browse.test.tsx
index 871265d4ece..a1a5e347b19 100644
--- a/public/app/features/plugins/admin/pages/Browse.test.tsx
+++ b/public/app/features/plugins/admin/pages/Browse.test.tsx
@@ -170,6 +170,7 @@ describe('Browse list of plugins', () => {
       expect(queryByText('Plugin 3')).not.toBeInTheDocument();
     });
   });
+
   describe('when searching', () => {
     it('should only list plugins matching search', async () => {
       const { queryByText } = renderBrowse('/plugins?filterBy=all&q=zabbix', [
diff --git a/public/app/features/plugins/admin/pages/PluginDetails.test.tsx b/public/app/features/plugins/admin/pages/PluginDetails.test.tsx
index 1b58b6f7161..b1601a4341f 100644
--- a/public/app/features/plugins/admin/pages/PluginDetails.test.tsx
+++ b/public/app/features/plugins/admin/pages/PluginDetails.test.tsx
@@ -9,7 +9,7 @@ import { getRouteComponentProps } from 'app/core/navigation/__mocks__/routeProps
 import { CatalogPlugin } from '../types';
 import * as api from '../api';
 import { mockPluginApis, getCatalogPluginMock, getPluginsStateMock } from '../__mocks__';
-import { PluginErrorCode } from '@grafana/data';
+import { PluginErrorCode, PluginSignatureStatus } from '@grafana/data';
 import { selectors } from '@grafana/e2e-selectors';
 
 // Mock the config to enable the plugin catalog
@@ -83,6 +83,51 @@ describe('Plugin details page', () => {
     await waitFor(() => expect(queryByText(/licensed under the apache 2.0 license/i)).toBeInTheDocument());
   });
 
+  it('should display the number of downloads in the header', async () => {
+    const downloads = 24324;
+    const { queryByText } = renderPluginDetails({ id, downloads });
+
+    await waitFor(() => expect(queryByText(new Intl.NumberFormat().format(downloads))).toBeInTheDocument());
+  });
+
+  it('should display the version in the header', async () => {
+    const version = '1.3.443';
+    const { queryByText } = renderPluginDetails({ id, version });
+
+    await waitFor(() => expect(queryByText(version)).toBeInTheDocument());
+  });
+
+  it('should display description in the header', async () => {
+    const description = 'This is my description';
+    const { queryByText } = renderPluginDetails({ id, description });
+
+    await waitFor(() => expect(queryByText(description)).toBeInTheDocument());
+  });
+
+  it('should display a "Signed" badge if the plugin signature is verified', async () => {
+    const { queryByText } = renderPluginDetails({ id, signature: PluginSignatureStatus.valid });
+
+    await waitFor(() => expect(queryByText('Signed')).toBeInTheDocument());
+  });
+
+  it('should display a "Missing signature" badge if the plugin signature is missing', async () => {
+    const { queryByText } = renderPluginDetails({ id, signature: PluginSignatureStatus.missing });
+
+    await waitFor(() => expect(queryByText('Missing signature')).toBeInTheDocument());
+  });
+
+  it('should display a "Modified signature" badge if the plugin signature is modified', async () => {
+    const { queryByText } = renderPluginDetails({ id, signature: PluginSignatureStatus.modified });
+
+    await waitFor(() => expect(queryByText('Modified signature')).toBeInTheDocument());
+  });
+
+  it('should display a "Invalid signature" badge if the plugin signature is invalid', async () => {
+    const { queryByText } = renderPluginDetails({ id, signature: PluginSignatureStatus.invalid });
+
+    await waitFor(() => expect(queryByText('Invalid signature')).toBeInTheDocument());
+  });
+
   it('should display version history in case it is available', async () => {
     const { queryByText, getByText, getByRole } = renderPluginDetails({
       id,