From 050dc7bc8f2e8ee9bf960fd4b4401b42d9aafc06 Mon Sep 17 00:00:00 2001 From: Dimitris Sotirakis Date: Wed, 18 Aug 2021 10:37:13 +0300 Subject: [PATCH] Cloudwatch: Unwrap errors - throw error from upstream (#36334) * Unwrap errors - throw error from upstream * Fixes according to reviewer's comments * Fix linting * Remove unused code --- pkg/api/metrics.go | 7 +++---- pkg/tsdb/cloudwatch/time_series_query.go | 6 ++++++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/pkg/api/metrics.go b/pkg/api/metrics.go index 32fae19b774..b8a1a76c4b5 100644 --- a/pkg/api/metrics.go +++ b/pkg/api/metrics.go @@ -6,14 +6,13 @@ import ( "net/http" "github.com/grafana/grafana-plugin-sdk-go/backend" - "github.com/grafana/grafana/pkg/expr" - "github.com/grafana/grafana/pkg/models" - "github.com/grafana/grafana/pkg/plugins" - "github.com/grafana/grafana/pkg/api/dtos" "github.com/grafana/grafana/pkg/api/response" "github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/components/simplejson" + "github.com/grafana/grafana/pkg/expr" + "github.com/grafana/grafana/pkg/models" + "github.com/grafana/grafana/pkg/plugins" "github.com/grafana/grafana/pkg/util" ) diff --git a/pkg/tsdb/cloudwatch/time_series_query.go b/pkg/tsdb/cloudwatch/time_series_query.go index c0a379c27db..95c472d2858 100644 --- a/pkg/tsdb/cloudwatch/time_series_query.go +++ b/pkg/tsdb/cloudwatch/time_series_query.go @@ -98,6 +98,12 @@ func (e *cloudWatchExecutor) executeTimeSeriesQuery(ctx context.Context, req *ba } if err := eg.Wait(); err != nil { + dataResponse := backend.DataResponse{ + Error: fmt.Errorf("metric request error: %q", err), + } + resultChan <- &responseWrapper{ + DataResponse: &dataResponse, + } return nil, err } close(resultChan)