From 054cd2d897e513942525f885663565f5d2f1bc97 Mon Sep 17 00:00:00 2001 From: Esteban Beltran Date: Wed, 15 Nov 2023 15:30:08 +0100 Subject: [PATCH] Revert js changes. use config --- conf/defaults.ini | 2 +- public/app/features/plugins/sandbox/utils.ts | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/conf/defaults.ini b/conf/defaults.ini index 33ef56bce97..173f4babdf5 100644 --- a/conf/defaults.ini +++ b/conf/defaults.ini @@ -382,7 +382,7 @@ angular_support_enabled = true csrf_always_check = false # Comma-separated list of plugins ids that won't be loaded inside the frontend sandbox -disable_frontend_sandbox_for_plugins = +disable_frontend_sandbox_for_plugins = grafana-incident-app [security.encryption] # Defines the time-to-live (TTL) for decrypted data encryption keys stored in memory (cache). diff --git a/public/app/features/plugins/sandbox/utils.ts b/public/app/features/plugins/sandbox/utils.ts index 14022fe8eb5..74305e594e4 100644 --- a/public/app/features/plugins/sandbox/utils.ts +++ b/public/app/features/plugins/sandbox/utils.ts @@ -38,8 +38,6 @@ export function logError(error: Error, context?: LogContext) { logErrorRuntime(error, context); } -const excludePluginSandbox = ['grafana-incident-app']; - export function isFrontendSandboxSupported({ isAngular, pluginId, @@ -49,8 +47,7 @@ export function isFrontendSandboxSupported({ }): boolean { // To fast test and debug the sandbox in the browser. const sandboxQueryParam = location.search.includes('nosandbox') && config.buildInfo.env === 'development'; - const isPluginExcepted = - config.disableFrontendSandboxForPlugins.includes(pluginId) || excludePluginSandbox.includes(pluginId); + const isPluginExcepted = config.disableFrontendSandboxForPlugins.includes(pluginId); return ( !isAngular && Boolean(config.featureToggles.pluginsFrontendSandbox) &&