diff --git a/public/app/features/alerting/unified/components/AlertingPageWrapper.tsx b/public/app/features/alerting/unified/components/AlertingPageWrapper.tsx index e6dd4a486f8..77a6a75d650 100644 --- a/public/app/features/alerting/unified/components/AlertingPageWrapper.tsx +++ b/public/app/features/alerting/unified/components/AlertingPageWrapper.tsx @@ -11,8 +11,11 @@ import { NoAlertManagerWarning } from './NoAlertManagerWarning'; /** * This is the main alerting page wrapper, used by the alertmanager page wrapper and the alert rules list view + * + * NOTE: we're omitting "title" here because it's not actually rendering the title (it's the html attribute "title"). + * Use "renderTitle" instead for custom page titles. */ -type AlertingPageWrapperProps = Omit & { +type AlertingPageWrapperProps = Omit & { isLoading?: boolean; children?: ReactNode; }; diff --git a/public/app/features/alerting/unified/group-details/GroupEditPage.tsx b/public/app/features/alerting/unified/group-details/GroupEditPage.tsx index a68f230d8cb..7d34486d59f 100644 --- a/public/app/features/alerting/unified/group-details/GroupEditPage.tsx +++ b/public/app/features/alerting/unified/group-details/GroupEditPage.tsx @@ -99,7 +99,7 @@ function GroupEditPage() { if (!!dsFeatures && !dsFeatures.rulerConfig) { return ( - + This group belongs to a data source that does not support editing. @@ -124,12 +124,7 @@ function GroupEditPage() { }; return ( - + <> {Boolean(dsFeaturesError) && ( + diff --git a/public/locales/en-US/grafana.json b/public/locales/en-US/grafana.json index e5cbc8978e4..5e9f8d224bc 100644 --- a/public/locales/en-US/grafana.json +++ b/public/locales/en-US/grafana.json @@ -1548,8 +1548,7 @@ "group-not-editable": "Selected group cannot be edited", "group-not-editable-description": "This group belongs to a data source that does not support editing.", "page-title": "Edit rule group", - "rule-group-error": "Error loading rule group", - "title": "Edit evaluation group" + "rule-group-error": "Error loading rule group" }, "group-loader": { "group-load-failed": "Failed to load rules from group {{ groupName }} in {{ namespaceName }}", @@ -1583,8 +1582,7 @@ "synthetic-monitoring-card-item-2": "Run ping, DNS, HTTP/S, and TCP checks at every network layer.", "synthetic-monitoring-card-item-3": "Use 20+ global probes or private probes behind your firewall.", "synthetic-monitoring-card-item-4": "Track SLOs with built-in Prometheus-style alerts — right from the UI.", - "synthetic-monitoring-card-title": "Synthetic Monitoring", - "title-alerting": "Alerting" + "synthetic-monitoring-card-title": "Synthetic Monitoring" }, "import-to-gma": { "action-button": "Import",