From 7ce766d9d4f555f56bace547c37c3b9254e8b79c Mon Sep 17 00:00:00 2001
From: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Date: Mon, 27 Nov 2017 11:32:03 +0100
Subject: [PATCH] dashlist: Support for clear all filters

---
 .../features/dashboard/dashboard_list_ctrl.ts | 11 ++++-
 .../dashboard/partials/dashboardList.html     | 12 ++++++
 .../specs/dashboard_list_ctrl.jest.ts         | 42 +++++++++++++++++++
 3 files changed, 64 insertions(+), 1 deletion(-)

diff --git a/public/app/features/dashboard/dashboard_list_ctrl.ts b/public/app/features/dashboard/dashboard_list_ctrl.ts
index ab62e3dfff6..08bba6450f9 100644
--- a/public/app/features/dashboard/dashboard_list_ctrl.ts
+++ b/public/app/features/dashboard/dashboard_list_ctrl.ts
@@ -10,6 +10,7 @@ export class DashboardListCtrl {
   navModel: any;
   canDelete = false;
   canMove = false;
+  hasFilters = false;
   selectAllChecked = false;
   starredFilterOptions = [{text: 'Filter by Starred', disabled: true}, {text: 'Yes'}, {text: 'No'}];
   selectedStarredFilter: any;
@@ -17,7 +18,7 @@ export class DashboardListCtrl {
   /** @ngInject */
   constructor(private backendSrv, navModelSrv, private $q, private searchSrv: SearchSrv) {
     this.navModel = navModelSrv.getNav('dashboards', 'dashboards');
-    this.query = {query: '', mode: 'tree', tag: []};
+    this.query = {query: '', mode: 'tree', tag: [], starred: false};
     this.selectedStarredFilter = this.starredFilterOptions[0];
 
     this.getDashboards().then(() => {
@@ -35,6 +36,7 @@ export class DashboardListCtrl {
     this.canMove = false;
     this.canDelete = false;
     this.selectAllChecked = false;
+    this.hasFilters = this.query.query.length > 0 || this.query.tag.length > 0 || this.query.starred;
 
     if (!result) {
       this.sections = [];
@@ -194,4 +196,11 @@ export class DashboardListCtrl {
 
     this.selectionChanged();
   }
+
+  clearFilters() {
+    this.query.query = '';
+    this.query.tag = [];
+    this.query.starred = false;
+    this.getDashboards();
+  }
 }
diff --git a/public/app/features/dashboard/partials/dashboardList.html b/public/app/features/dashboard/partials/dashboardList.html
index 4c574c5a5ba..c9822efe561 100644
--- a/public/app/features/dashboard/partials/dashboardList.html
+++ b/public/app/features/dashboard/partials/dashboardList.html
@@ -32,6 +32,18 @@
       </span>
     </div>
 
+    <div class="gf-form">
+        <div class="gf-form-button-row"
+          ng-show="ctrl.hasFilters">
+          <button
+            type="button"
+            class="btn gf-form-button btn-inverse btn-small"
+            ng-click="ctrl.clearFilters()">
+            <i class="fa fa-close"></i> Clear current search query and filters
+        </button>
+        </div>
+    </div>
+
     <div class="gf-form-group">
       <div class="gf-form-button-row">
         <button	type="button"
diff --git a/public/app/features/dashboard/specs/dashboard_list_ctrl.jest.ts b/public/app/features/dashboard/specs/dashboard_list_ctrl.jest.ts
index fda720ce87f..c159b7eeb2b 100644
--- a/public/app/features/dashboard/specs/dashboard_list_ctrl.jest.ts
+++ b/public/app/features/dashboard/specs/dashboard_list_ctrl.jest.ts
@@ -124,6 +124,10 @@ describe('DashboardListCtrl', () => {
         expect(ctrl.canDelete).toBeFalsy();
       });
 
+      it('should have active filters', () => {
+        expect(ctrl.hasFilters).toBeTruthy();
+      });
+
       describe('when select all is checked', () => {
         beforeEach(() => {
           ctrl.selectAllChecked = true;
@@ -143,6 +147,16 @@ describe('DashboardListCtrl', () => {
         it('should enable delete button', () => {
           expect(ctrl.canDelete).toBeTruthy();
         });
+
+        describe('when clearing filters', () => {
+          beforeEach(() => {
+            return ctrl.clearFilters();
+          });
+
+          it('should reset query filter', () => {
+            expect(ctrl.query.query).toEqual('');
+          });
+        });
       });
     });
 
@@ -155,6 +169,20 @@ describe('DashboardListCtrl', () => {
         expect(ctrl.sections.length).toEqual(1);
         expect(ctrl.query.tag[0]).toEqual('test');
       });
+
+      it('should have active filters', () => {
+        expect(ctrl.hasFilters).toBeTruthy();
+      });
+
+      describe('when clearing filters', () => {
+        beforeEach(() => {
+          return ctrl.clearFilters();
+        });
+
+        it('should reset tag filter', () => {
+          expect(ctrl.query.tag.length).toEqual(0);
+        });
+      });
     });
 
     describe('with starred filter', () => {
@@ -169,6 +197,20 @@ describe('DashboardListCtrl', () => {
         expect(ctrl.sections.length).toEqual(1);
         expect(ctrl.query.starred).toEqual(true);
       });
+
+      it('should have active filters', () => {
+        expect(ctrl.hasFilters).toBeTruthy();
+      });
+
+      describe('when clearing filters', () => {
+        beforeEach(() => {
+          return ctrl.clearFilters();
+        });
+
+        it('should reset starred filter', () => {
+          expect(ctrl.query.starred).toEqual(false);
+        });
+      });
     });
   });