Unistore : Ensure Watch works in HA mode. (#93428)

* Replace Watch with WatchNext

* remove watchset

* fix previous page and closing the channel

* Remove the broadcaster cache to prevent dupplicated events

* add watch bookmark

* add watch bookmark

* cleanup comments

* disable the tests for bookmarks for now

* Ensure we send previosu events

* lint

* re-introduce the cache

* load from cache

* disabling legacy test

* disabling legacy test

* Update pkg/storage/unified/resource/server.go

Co-authored-by: Diego Augusto Molina <diegoaugustomolina@gmail.com>

* Could not read previous events

* add proper migration

* Add previous_resource_version to both history and resource

* First event should have an RV of 2 and not 1

* Test both storage backends

* fix the inital RV for the sql backend

* ensure graceful stop of the stream decoder

* gocyclo

---------

Co-authored-by: Diego Augusto Molina <diegoaugustomolina@gmail.com>

pkg/storage/unified/sql/testdata/mysql--resource_history_insert-insert into resource_history.sql

@@ -5,6 +5,7 @@ INSERT INTO `resource_history`
         `resource`,
         `namespace`,
         `name`,
+        `previous_resource_version`,
         `value`,
         `action`
     )
@@ -14,6 +15,7 @@ INSERT INTO `resource_history`
         '',
         '',
         '',
+        1234,
         '[]',
         'UNKNOWN'
     )

pkg/storage/unified/sql/testdata/mysql--resource_history_poll-single path.sql

@@ -0,0 +1,16 @@
+SELECT
+    `resource_version`,
+    `namespace`,
+    `group`,
+    `resource`,
+    `name`,
+    `value`,
+    `action`,
+    `previous_resource_version`
+    FROM `resource_history`
+    WHERE 1 = 1
+    AND `group` = 'group'
+    AND `resource` = 'res'
+    AND `resource_version` > 1234
+    ORDER BY `resource_version` ASC
+;

pkg/storage/unified/sql/testdata/mysql--resource_insert-simple.sql

@@ -5,6 +5,7 @@ INSERT INTO `resource`
         `resource`,
         `namespace`,
         `name`,
+        `previous_resource_version`,
         `value`,
         `action`
     )
@@ -14,6 +15,7 @@ INSERT INTO `resource`
         'rr',
         'nn',
         'name',
+        123,
         '[]',
         'ADDED'
     )

pkg/storage/unified/sql/testdata/mysql--resource_version_insert-single path.sql

@@ -7,6 +7,6 @@ INSERT INTO `resource_version`
     VALUES (
         '',
         '',
-        1
+        2
     )
 ;

pkg/storage/unified/sql/testdata/postgres--resource_history_insert-insert into resource_history.sql

@@ -5,6 +5,7 @@ INSERT INTO "resource_history"
         "resource",
         "namespace",
         "name",
+        "previous_resource_version",
         "value",
         "action"
     )
@@ -14,6 +15,7 @@ INSERT INTO "resource_history"
         '',
         '',
         '',
+        1234,
         '[]',
         'UNKNOWN'
     )

pkg/storage/unified/sql/testdata/postgres--resource_history_poll-single path.sql

@@ -0,0 +1,16 @@
+SELECT
+    "resource_version",
+    "namespace",
+    "group",
+    "resource",
+    "name",
+    "value",
+    "action",
+    "previous_resource_version"
+    FROM "resource_history"
+    WHERE 1 = 1
+    AND "group" = 'group'
+    AND "resource" = 'res'
+    AND "resource_version" > 1234
+    ORDER BY "resource_version" ASC
+;

pkg/storage/unified/sql/testdata/postgres--resource_insert-simple.sql

@@ -5,6 +5,7 @@ INSERT INTO "resource"
         "resource",
         "namespace",
         "name",
+        "previous_resource_version",
         "value",
         "action"
     )
@@ -14,6 +15,7 @@ INSERT INTO "resource"
         'rr',
         'nn',
         'name',
+        123,
         '[]',
         'ADDED'
     )

pkg/storage/unified/sql/testdata/postgres--resource_version_insert-single path.sql

@@ -7,6 +7,6 @@ INSERT INTO "resource_version"
     VALUES (
         '',
         '',
-        1
+        2
     )
 ;

pkg/storage/unified/sql/testdata/sqlite--resource_history_insert-insert into resource_history.sql

@@ -5,6 +5,7 @@ INSERT INTO "resource_history"
         "resource",
         "namespace",
         "name",
+        "previous_resource_version",
         "value",
         "action"
     )
@@ -14,6 +15,7 @@ INSERT INTO "resource_history"
         '',
         '',
         '',
+        1234,
         '[]',
         'UNKNOWN'
     )

pkg/storage/unified/sql/testdata/sqlite--resource_history_poll-single path.sql

@@ -0,0 +1,16 @@
+SELECT
+    "resource_version",
+    "namespace",
+    "group",
+    "resource",
+    "name",
+    "value",
+    "action",
+    "previous_resource_version"
+    FROM "resource_history"
+    WHERE 1 = 1
+    AND "group" = 'group'
+    AND "resource" = 'res'
+    AND "resource_version" > 1234
+    ORDER BY "resource_version" ASC
+;

pkg/storage/unified/sql/testdata/sqlite--resource_insert-simple.sql

@@ -5,6 +5,7 @@ INSERT INTO "resource"
         "resource",
         "namespace",
         "name",
+        "previous_resource_version",
         "value",
         "action"
     )
@@ -14,6 +15,7 @@ INSERT INTO "resource"
         'rr',
         'nn',
         'name',
+        123,
         '[]',
         'ADDED'
     )

pkg/storage/unified/sql/testdata/sqlite--resource_version_insert-single path.sql

@@ -7,6 +7,6 @@ INSERT INTO "resource_version"
     VALUES (
         '',
         '',
-        1
+        2
     )
 ;