From 0ceeb18269765b40eb5cf7bf2536894152d5e5e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Laura=20Fern=C3=A1ndez?= Date: Mon, 18 Sep 2023 12:57:11 +0200 Subject: [PATCH] Navigation: Create feature toggle for `dockedMegaMenu` (#74985) --- .../configure-grafana/feature-toggles/index.md | 1 + packages/grafana-data/src/types/featureToggles.gen.ts | 1 + pkg/services/featuremgmt/registry.go | 7 +++++++ pkg/services/featuremgmt/toggles_gen.csv | 1 + pkg/services/featuremgmt/toggles_gen.go | 4 ++++ 5 files changed, 14 insertions(+) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 4d90b23d636..de0f9846254 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -59,6 +59,7 @@ Some features are enabled by default. You can disable these feature by setting t | `newDBLibrary` | Use jmoiron/sqlx rather than xorm for a few backend services | | `autoMigrateOldPanels` | Migrate old angular panels to supported versions (graph, table-old, worldmap, etc) | | `disableAngular` | Dynamic flag to disable angular at runtime. The preferred method is to set `angular_support_enabled` to `false` in the [security] settings, which allows you to change the state at runtime. | +| `dockedMegaMenu` | Enable support for a persistent (docked) navigation menu | | `grpcServer` | Run the GRPC server | | `accessControlOnCall` | Access control primitives for OnCall | | `nestedFolders` | Enable folder nesting | diff --git a/packages/grafana-data/src/types/featureToggles.gen.ts b/packages/grafana-data/src/types/featureToggles.gen.ts index 541ad9d44e8..5282959cfb6 100644 --- a/packages/grafana-data/src/types/featureToggles.gen.ts +++ b/packages/grafana-data/src/types/featureToggles.gen.ts @@ -41,6 +41,7 @@ export interface FeatureToggles { logRequestsInstrumentedAsUnknown?: boolean; dataConnectionsConsole?: boolean; topnav?: boolean; + dockedMegaMenu?: boolean; grpcServer?: boolean; entityStore?: boolean; cloudWatchCrossAccountQuerying?: boolean; diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index b134414c6e1..d4fb605e641 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -161,6 +161,13 @@ var ( Expression: "true", // enabled by default Owner: grafanaFrontendPlatformSquad, }, + { + Name: "dockedMegaMenu", + Description: "Enable support for a persistent (docked) navigation menu", + Stage: FeatureStagePublicPreview, + FrontendOnly: true, + Owner: grafanaFrontendPlatformSquad, + }, { Name: "grpcServer", Description: "Run the GRPC server", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index 08a02bcb957..965a79f4495 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -22,6 +22,7 @@ disableSecretsCompatibility,experimental,@grafana/hosted-grafana-team,false,fals logRequestsInstrumentedAsUnknown,experimental,@grafana/hosted-grafana-team,false,false,false,false dataConnectionsConsole,GA,@grafana/plugins-platform-backend,false,false,false,false topnav,deprecated,@grafana/grafana-frontend-platform,false,false,false,false +dockedMegaMenu,preview,@grafana/grafana-frontend-platform,false,false,false,true grpcServer,preview,@grafana/grafana-app-platform-squad,false,false,false,false entityStore,experimental,@grafana/grafana-app-platform-squad,true,false,false,false cloudWatchCrossAccountQuerying,GA,@grafana/aws-datasources,false,false,false,false diff --git a/pkg/services/featuremgmt/toggles_gen.go b/pkg/services/featuremgmt/toggles_gen.go index 954a4471e88..df546f241ff 100644 --- a/pkg/services/featuremgmt/toggles_gen.go +++ b/pkg/services/featuremgmt/toggles_gen.go @@ -99,6 +99,10 @@ const ( // Enables topnav support in external plugins. The new Grafana navigation cannot be disabled. FlagTopnav = "topnav" + // FlagDockedMegaMenu + // Enable support for a persistent (docked) navigation menu + FlagDockedMegaMenu = "dockedMegaMenu" + // FlagGrpcServer // Run the GRPC server FlagGrpcServer = "grpcServer"