From 0e8f0d4b4ab7b204113a01a2d846a0b90ee8f42d Mon Sep 17 00:00:00 2001
From: Gilles De Mey <gilles.de.mey@gmail.com>
Date: Mon, 28 Nov 2022 12:31:38 +0100
Subject: [PATCH] Alerting: fix "no permissions" alert flashing (#59300)
 (#59374)

---
 .../alerting/unified/ExistingRuleEditor.tsx      | 16 ++++++++++++++--
 .../alerting/unified/hooks/useIsRuleEditable.ts  |  1 -
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/public/app/features/alerting/unified/ExistingRuleEditor.tsx b/public/app/features/alerting/unified/ExistingRuleEditor.tsx
index 612b7c345cd..2a704fcff05 100644
--- a/public/app/features/alerting/unified/ExistingRuleEditor.tsx
+++ b/public/app/features/alerting/unified/ExistingRuleEditor.tsx
@@ -19,9 +19,21 @@ interface ExistingRuleEditorProps {
 
 export function ExistingRuleEditor({ identifier }: ExistingRuleEditorProps) {
   useCleanup((state) => (state.unifiedAlerting.ruleForm.existingRule = initialAsyncRequestState));
-  const { loading, result, error, dispatched } = useUnifiedAlertingSelector((state) => state.ruleForm.existingRule);
+
+  const {
+    loading: loadingAlertRule,
+    result,
+    error,
+    dispatched,
+  } = useUnifiedAlertingSelector((state) => state.ruleForm.existingRule);
+
   const dispatch = useDispatch();
-  const { isEditable } = useIsRuleEditable(ruleId.ruleIdentifierToRuleSourceName(identifier), result?.rule);
+  const { isEditable, loading: loadingEditable } = useIsRuleEditable(
+    ruleId.ruleIdentifierToRuleSourceName(identifier),
+    result?.rule
+  );
+
+  const loading = loadingAlertRule || loadingEditable;
 
   useEffect(() => {
     if (!dispatched) {
diff --git a/public/app/features/alerting/unified/hooks/useIsRuleEditable.ts b/public/app/features/alerting/unified/hooks/useIsRuleEditable.ts
index b2b97cdecfb..150f4ee00ef 100644
--- a/public/app/features/alerting/unified/hooks/useIsRuleEditable.ts
+++ b/public/app/features/alerting/unified/hooks/useIsRuleEditable.ts
@@ -18,7 +18,6 @@ export function useIsRuleEditable(rulesSourceName: string, rule?: RulerRuleDTO):
   const folderUID = rule && isGrafanaRulerRule(rule) ? rule.grafana_alert.namespace_uid : undefined;
 
   const rulePermission = getRulesPermissions(rulesSourceName);
-
   const { folder, loading } = useFolder(folderUID);
 
   if (!rule) {