public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Alerting: Remove feature toggle for custom recovery threshold (#104455)

Browse Source
This commit is contained in:
Gilles De Mey
2025-04-24 11:58:17 -04:00
committed by GitHub
parent 674fdd1d32
commit 109267ab03
13 changed files with 247 additions and 312 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/featuremgmt/registry.go
-9
View File
@@ -590,15 +590,6 @@ var (
Stage: FeatureStagePublicPreview,
Owner: awsDatasourcesSquad,
},
{
Name: "recoveryThreshold",
Description: "Enables feature recovery threshold (aka hysteresis) for threshold server-side expression",
Stage: FeatureStageGeneralAvailability,
FrontendOnly: false,
Owner: grafanaAlertingSquad,
RequiresRestart: true,
Expression: "true",
},
{
Name: "lokiStructuredMetadata",
Description: "Enables the loki data source to request structured metadata from the Loki server",
pkg/services/featuremgmt/toggles_gen.csv
-1
View File
@@ -77,7 +77,6 @@ queryServiceRewrite,experimental,@grafana/grafana-datasources-core-services,fals
queryServiceFromUI,experimental,@grafana/grafana-datasources-core-services,false,false,true
queryServiceFromExplore,experimental,@grafana/grafana-datasources-core-services,false,false,true
cloudWatchBatchQueries,preview,@grafana/aws-datasources,false,false,false
recoveryThreshold,GA,@grafana/alerting-squad,false,true,false
lokiStructuredMetadata,GA,@grafana/observability-logs,false,false,false
cachingOptimizeSerializationMemoryUsage,experimental,@grafana/grafana-operator-experience-squad,false,false,false
prometheusCodeModeMetricNamesSearch,experimental,@grafana/oss-big-tent,false,false,true
1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
77 queryServiceFromUI experimental @grafana/grafana-datasources-core-services false false true
78 queryServiceFromExplore experimental @grafana/grafana-datasources-core-services false false true
79 cloudWatchBatchQueries preview @grafana/aws-datasources false false false
recoveryThreshold GA @grafana/alerting-squad false true false
80 lokiStructuredMetadata GA @grafana/observability-logs false false false
81 cachingOptimizeSerializationMemoryUsage experimental @grafana/grafana-operator-experience-squad false false false
82 prometheusCodeModeMetricNamesSearch experimental @grafana/oss-big-tent false false true
pkg/services/featuremgmt/toggles_gen.go
-4
View File
@@ -319,10 +319,6 @@ const (
// Runs CloudWatch metrics queries as separate batches
FlagCloudWatchBatchQueries = "cloudWatchBatchQueries"
// FlagRecoveryThreshold
// Enables feature recovery threshold (aka hysteresis) for threshold server-side expression
FlagRecoveryThreshold = "recoveryThreshold"
// FlagLokiStructuredMetadata
// Enables the loki data source to request structured metadata from the Loki server
FlagLokiStructuredMetadata = "lokiStructuredMetadata"
pkg/services/featuremgmt/toggles_gen.json
+238 -278
View File
File diff suppressed because it is too large Load Diff
pkg/services/ngalert/eval/eval_test.go
+1 -1
View File
@@ -710,7 +710,7 @@ func TestCreate_HysteresisCommand(t *testing.T) {
cache: cacheService,
pluginsStore: store,
})
evaluator := NewEvaluatorFactory(setting.UnifiedAlertingSettings{}, cacheService, expr.ProvideService(&setting.Cfg{ExpressionsEnabled: true}, nil, nil, featuremgmt.WithFeatures(featuremgmt.FlagRecoveryThreshold), nil, tracing.InitializeTracerForTest()))
evaluator := NewEvaluatorFactory(setting.UnifiedAlertingSettings{}, cacheService, expr.ProvideService(&setting.Cfg{ExpressionsEnabled: true}, nil, nil, featuremgmt.WithFeatures(), nil, tracing.InitializeTracerForTest()))
evalCtx := NewContextWithPreviousResults(context.Background(), u, testCase.reader)
eval, err := evaluator.Create(evalCtx, condition)