[v9.5.x] Alerting: No longer silence paused alerts during legacy migration (#71765)

Alerting: No longer silence paused alerts during legacy migration (#71596)

* Alerting: No longer silence paused alerts during legacy migration

Now that we migrate paused legacy alerts to paused UA alert rules, we no longer need to silence them.

(cherry picked from commit 8c6cdf51fc)

pkg/services/sqlstore/migrations/ualert/alert_rule.go

@@ -152,10 +152,6 @@ func (m *migration) makeAlertRule(l log.Logger, cond condition, da dashAlert, fo
 	n, v := getLabelForSilenceMatching(ar.UID)
 	ar.Labels[n] = v
 
-	if err := m.addSilence(da, ar); err != nil {
-		m.mg.Logger.Error("alert migration error: failed to create silence", "rule_name", ar.Title, "err", err)
-	}
-
 	if err := m.addErrorSilence(da, ar); err != nil {
 		m.mg.Logger.Error("alert migration error: failed to create silence for Error", "rule_name", ar.Title, "err", err)
 	}

pkg/services/sqlstore/migrations/ualert/silences.go

@@ -26,43 +26,6 @@ const (
 	ErrorAlertName = "DatasourceError"
 )
 
-func (m *migration) addSilence(da dashAlert, rule *alertRule) error {
-	if da.State != "paused" {
-		return nil
-	}
-
-	uid, err := uuid.NewRandom()
-	if err != nil {
-		return errors.New("failed to create uuid for silence")
-	}
-
-	n, v := getLabelForSilenceMatching(rule.UID)
-	s := &pb.MeshSilence{
-		Silence: &pb.Silence{
-			Id: uid.String(),
-			Matchers: []*pb.Matcher{
-				{
-					Type:    pb.Matcher_EQUAL,
-					Name:    n,
-					Pattern: v,
-				},
-			},
-			StartsAt:  time.Now(),
-			EndsAt:    time.Now().Add(365 * 20 * time.Hour), // 1 year.
-			CreatedBy: "Grafana Migration",
-			Comment:   "Created during auto migration to unified alerting",
-		},
-		ExpiresAt: time.Now().Add(365 * 20 * time.Hour), // 1 year.
-	}
-
-	_, ok := m.silences[da.OrgId]
-	if !ok {
-		m.silences[da.OrgId] = make([]*pb.MeshSilence, 0)
-	}
-	m.silences[da.OrgId] = append(m.silences[da.OrgId], s)
-	return nil
-}
-
 func (m *migration) addErrorSilence(da dashAlert, rule *alertRule) error {
 	if da.ParsedSettings.ExecutionErrorState != "keep_state" {
 		return nil