[Alerting]: Assign UUID to grafana receivers (#34241)

* [Alerting]: Assign UUID to grafana receivers

* Apply suggestions from code review

* Add test for updating invalid receiver

Co-authored-by: Domas <domasx2@gmail.com>

pkg/tests/api/alerting/api_alertmanager_configuration_test.go

@@ -1,12 +1,15 @@
 package alerting
 
 import (
+	"encoding/json"
 	"fmt"
 	"net/http"
 	"testing"
 
 	"github.com/grafana/grafana/pkg/models"
+	"github.com/grafana/grafana/pkg/services/ngalert/api/tooling/definitions"
 	"github.com/grafana/grafana/pkg/tests/testinfra"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -74,6 +77,7 @@ func TestAlertmanagerConfigurationPersistSecrets(t *testing.T) {
 	store := testinfra.SetUpDatabase(t, dir)
 	grafanaListedAddr := testinfra.StartGrafana(t, dir, path, store)
 	alertConfigURL := fmt.Sprintf("http://%s/api/alertmanager/grafana/config/api/v1/alerts", grafanaListedAddr)
+	generatedUID := ""
 
 	// create a new configuration that has a secret
 	{
@@ -105,9 +109,56 @@ func TestAlertmanagerConfigurationPersistSecrets(t *testing.T) {
 		resp := postRequest(t, alertConfigURL, payload, http.StatusAccepted) // nolint
 		require.JSONEq(t, `{"message":"configuration created"}`, getBody(t, resp.Body))
 	}
-	// Then, update the recipient
+
+	// Try to update a receiver with unknown UID
 	{
+		// Then, update the recipient
 		payload := `
+	{
+		"template_files": {},
+		"alertmanager_config": {
+			"route": {
+				"receiver": "slack.receiver"
+			},
+			"templates": null,
+			"receivers": [{
+				"name": "slack.receiver",
+				"grafana_managed_receiver_configs": [{
+					"settings": {
+						"recipient": "#unified-alerting-test-but-updated"
+					},
+					"secureFields": {
+						"url": true
+					},
+					"type": "slack",
+					"name": "slack.receiver",
+					"disableResolveMessage": false,
+					"uid": "invalid"
+				}]
+			}]
+		}
+	}
+	`
+
+		resp := postRequest(t, alertConfigURL, payload, http.StatusBadRequest) // nolint
+		require.JSONEq(t, `{"message": "unknown receiver: invalid"}`, getBody(t, resp.Body))
+	}
+
+	// The secure settings must be present
+	{
+		resp := getRequest(t, alertConfigURL, http.StatusOK) // nolint
+		var c definitions.GettableUserConfig
+		bb := getBody(t, resp.Body)
+		err := json.Unmarshal([]byte(bb), &c)
+		require.NoError(t, err)
+		m := c.GetGrafanaReceiverMap()
+		assert.Len(t, m, 1)
+		for k := range m {
+			generatedUID = m[k].UID
+		}
+
+		// Then, update the recipient
+		payload := fmt.Sprintf(`
 {
 	"template_files": {},
 	"alertmanager_config": {
@@ -126,20 +177,22 @@ func TestAlertmanagerConfigurationPersistSecrets(t *testing.T) {
 				},
 				"type": "slack",
 				"name": "slack.receiver",
-				"disableResolveMessage": false
+				"disableResolveMessage": false,
+				"uid": %q
 			}]
 		}]
 	}
 }
-`
-		resp := postRequest(t, alertConfigURL, payload, http.StatusAccepted) // nolint
+`, generatedUID)
+
+		resp = postRequest(t, alertConfigURL, payload, http.StatusAccepted) // nolint
 		require.JSONEq(t, `{"message": "configuration created"}`, getBody(t, resp.Body))
 	}
 
 	// The secure settings must be present
 	{
 		resp := getRequest(t, alertConfigURL, http.StatusOK) // nolint
-		require.JSONEq(t, `
+		require.JSONEq(t, fmt.Sprintf(`
 {
 	"template_files": {},
 	"alertmanager_config": {
@@ -150,7 +203,7 @@ func TestAlertmanagerConfigurationPersistSecrets(t *testing.T) {
 		"receivers": [{
 			"name": "slack.receiver",
 			"grafana_managed_receiver_configs": [{
-				"uid": "",
+				"uid": %q,
 				"name": "slack.receiver",
 				"type": "slack",
 				"disableResolveMessage": false,
@@ -164,6 +217,6 @@ func TestAlertmanagerConfigurationPersistSecrets(t *testing.T) {
 		}]
 	}
 }
-`, getBody(t, resp.Body))
+`, generatedUID), getBody(t, resp.Body))
 	}
 }