Chore: Delete UpdateUser, ChangeUserPassword, UpdateLastSeenAt from sqlstore (#55928)

pkg/services/user/userimpl/store_test.go

@@ -2,6 +2,7 @@ package userimpl
 
 import (
 	"context"
+	"fmt"
 	"testing"
 	"time"
 
@@ -194,4 +195,97 @@ func TestIntegrationUserDataAccess(t *testing.T) {
 
 		ss.Cfg.CaseInsensitiveLogin = false
 	})
+
+	t.Run("Change user password", func(t *testing.T) {
+		err := userStore.ChangePassword(context.Background(), &user.ChangeUserPasswordCommand{})
+		require.NoError(t, err)
+	})
+
+	t.Run("update last seen at", func(t *testing.T) {
+		err := userStore.UpdateLastSeenAt(context.Background(), &user.UpdateUserLastSeenAtCommand{})
+		require.NoError(t, err)
+	})
+}
+
+func TestIntegrationUserUpdate(t *testing.T) {
+	if testing.Short() {
+		t.Skip("skipping integration test")
+	}
+
+	ss := sqlstore.InitTestDB(t)
+	userStore := ProvideStore(ss, setting.NewCfg())
+
+	users := createFiveTestUsers(t, ss, func(i int) *user.CreateUserCommand {
+		return &user.CreateUserCommand{
+			Email:      fmt.Sprint("USER", i, "@test.com"),
+			Name:       fmt.Sprint("USER", i),
+			Login:      fmt.Sprint("loginUSER", i),
+			IsDisabled: false,
+		}
+	})
+
+	userStore.cfg.CaseInsensitiveLogin = true
+
+	t.Run("Testing DB - update generates duplicate user", func(t *testing.T) {
+		err := userStore.Update(context.Background(), &user.UpdateUserCommand{
+			Login:  "loginuser2",
+			UserID: users[0].ID,
+		})
+
+		require.Error(t, err)
+	})
+
+	t.Run("Testing DB - update lowercases existing user", func(t *testing.T) {
+		err := userStore.Update(context.Background(), &user.UpdateUserCommand{
+			Login:  "loginUSER0",
+			Email:  "USER0@test.com",
+			UserID: users[0].ID,
+		})
+		require.NoError(t, err)
+
+		result, err := userStore.GetByID(context.Background(), users[0].ID)
+		require.NoError(t, err)
+
+		require.Equal(t, "loginuser0", result.Login)
+		require.Equal(t, "user0@test.com", result.Email)
+	})
+
+	t.Run("Testing DB - no user info provided", func(t *testing.T) {
+		err := userStore.Update(context.Background(), &user.UpdateUserCommand{
+			Login:  "",
+			Email:  "",
+			Name:   "Change Name",
+			UserID: users[3].ID,
+		})
+		require.NoError(t, err)
+
+		// query := user.GetUserByIDQuery{ID: users[3].ID}
+		result, err := userStore.GetByID(context.Background(), users[3].ID)
+		require.NoError(t, err)
+
+		// Changed
+		require.Equal(t, "Change Name", result.Name)
+
+		// Unchanged
+		require.Equal(t, "loginUSER3", result.Login)
+		require.Equal(t, "USER3@test.com", result.Email)
+	})
+
+	ss.Cfg.CaseInsensitiveLogin = false
+}
+
+func createFiveTestUsers(t *testing.T, sqlStore *sqlstore.SQLStore, fn func(i int) *user.CreateUserCommand) []user.User {
+	t.Helper()
+
+	users := []user.User{}
+	for i := 0; i < 5; i++ {
+		cmd := fn(i)
+
+		user, err := sqlStore.CreateUser(context.Background(), *cmd)
+		users = append(users, *user)
+
+		require.Nil(t, err)
+	}
+
+	return users
 }