public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Unexport mocks, use aws-sdk-go helpers, rename test utilities file (#46107)

Browse Source
This commit is contained in:
Shirley
2022-03-03 09:42:51 +01:00
committed by GitHub
parent c863676b65
commit 1255f8a76a
5 changed files with 49 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/tsdb/cloudwatch/annotation_query_test.go
+6 -6
View File
@@ -22,13 +22,13 @@ func TestQuery_AnnotationQuery(t *testing.T) {
NewCWClient = origNewCWClient
})
var client FakeCWAnnotationsClient
var client fakeCWAnnotationsClient
NewCWClient = func(sess *session.Session) cloudwatchiface.CloudWatchAPI {
return &client
}
t.Run("DescribeAlarmsForMetric is called with minimum parameters", func(t *testing.T) {
client = FakeCWAnnotationsClient{describeAlarmsForMetricOutput: &cloudwatch.DescribeAlarmsForMetricOutput{}}
client = fakeCWAnnotationsClient{describeAlarmsForMetricOutput: &cloudwatch.DescribeAlarmsForMetricOutput{}}
im := datasource.NewInstanceManager(func(s backend.DataSourceInstanceSettings) (instancemgmt.Instance, error) {
return datasourceInfo{}, nil
})
@@ -62,7 +62,7 @@ func TestQuery_AnnotationQuery(t *testing.T) {
})
t.Run("DescribeAlarms is called when prefixMatching is true", func(t *testing.T) {
client = FakeCWAnnotationsClient{describeAlarmsOutput: &cloudwatch.DescribeAlarmsOutput{}}
client = fakeCWAnnotationsClient{describeAlarmsOutput: &cloudwatch.DescribeAlarmsOutput{}}
im := datasource.NewInstanceManager(func(s backend.DataSourceInstanceSettings) (instancemgmt.Instance, error) {
return datasourceInfo{}, nil
})
@@ -91,9 +91,9 @@ func TestQuery_AnnotationQuery(t *testing.T) {
require.Len(t, client.calls.describeAlarms, 1)
assert.Equal(t, &cloudwatch.DescribeAlarmsInput{
MaxRecords: pointerInt64(100),
ActionPrefix: pointerString("some_action_prefix"),
AlarmNamePrefix: pointerString("some_alarm_name_prefix"),
MaxRecords: aws.Int64(100),
ActionPrefix: aws.String("some_action_prefix"),
AlarmNamePrefix: aws.String("some_alarm_name_prefix"),
}, client.calls.describeAlarms[0])
})
}