UI Extensions: Rename placement to extensionPointId (#65841)

* UI Extensions: Rename `placement` to `extensionPointId`

* Fix tests.

* Fix conflicts and review notes

* Remove `placement` from some other places
This commit is contained in:
Levente Balogh
2023-04-03 18:59:54 +03:00
committed by GitHub
parent 44ccd73d46
commit 1380fa54d6
16 changed files with 126 additions and 124 deletions
@@ -9,10 +9,10 @@ describe('Plugin Extensions / Get Plugin Extensions', () => {
const getter: GetPluginExtensions = jest.fn().mockReturnValue({ extensions: [] });
setPluginExtensionGetter(getter);
getPluginExtensions({ placement: 'panel-menu' });
getPluginExtensions({ extensionPointId: 'panel-menu' });
expect(getter).toHaveBeenCalledTimes(1);
expect(getter).toHaveBeenCalledWith({ placement: 'panel-menu' });
expect(getter).toHaveBeenCalledWith({ extensionPointId: 'panel-menu' });
});
test('should throw an error when trying to redefine the app-wide extension-getter function', () => {
@@ -33,7 +33,7 @@ describe('Plugin Extensions / Get Plugin Extensions', () => {
setPluginExtensionGetter(undefined);
expect(() => {
getPluginExtensions({ placement: 'panel-menu' });
getPluginExtensions({ extensionPointId: 'panel-menu' });
}).toThrowError();
});
});
@@ -1,10 +1,10 @@
import { PluginExtension } from '@grafana/data';
export type GetPluginExtensions = ({
placement,
extensionPointId,
context,
}: {
placement: string;
extensionPointId: string;
context?: object | Record<string | symbol, unknown>;
}) => {
extensions: PluginExtension[];