From 13dd821961999642d4746c4abf1cbf3c3ede7c93 Mon Sep 17 00:00:00 2001 From: Sven Grossmann Date: Fri, 30 Jun 2023 11:35:43 +0200 Subject: [PATCH] Loki: Fix wrong query expression with inline comments (#70947) fix remove comments from query --- public/app/plugins/datasource/loki/modifyQuery.test.ts | 1 + public/app/plugins/datasource/loki/modifyQuery.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/public/app/plugins/datasource/loki/modifyQuery.test.ts b/public/app/plugins/datasource/loki/modifyQuery.test.ts index ae9d9ad8817..6d831690fd3 100644 --- a/public/app/plugins/datasource/loki/modifyQuery.test.ts +++ b/public/app/plugins/datasource/loki/modifyQuery.test.ts @@ -161,6 +161,7 @@ describe('removeCommentsFromQuery', () => { ${'{job="grafana", bar="baz"} |="test" | logfmt | label_format level=lvl #hello'} | ${'{job="grafana", bar="baz"} |="test" | logfmt | label_format level=lvl '} ${`#sum(rate(\n{host="containers"}\n#[1m]))`} | ${`\n{host="containers"}\n`} ${`#sum(rate(\n{host="containers"}\n#| logfmt\n#[1m]))`} | ${`\n{host="containers"}\n\n`} + ${'{job="grafana"}\n#hello\n| logfmt'} | ${'{job="grafana"}\n\n| logfmt'} `('strips comments in log query: {$query}', ({ query, expectedResult }) => { expect(removeCommentsFromQuery(query)).toBe(expectedResult); }); diff --git a/public/app/plugins/datasource/loki/modifyQuery.ts b/public/app/plugins/datasource/loki/modifyQuery.ts index 69804e9e5de..e69a08b7ae8 100644 --- a/public/app/plugins/datasource/loki/modifyQuery.ts +++ b/public/app/plugins/datasource/loki/modifyQuery.ts @@ -241,6 +241,7 @@ export function removeCommentsFromQuery(query: string): string { newQuery = newQuery + query.substring(prev, lineCommentPosition.from); prev = lineCommentPosition.to; } + newQuery = newQuery + query.substring(prev); return newQuery; }