From 156eb7dfee8a2c6a287ae47f0d72dcc0a7a5b852 Mon Sep 17 00:00:00 2001 From: Dominik Prokop Date: Wed, 18 Oct 2023 12:22:46 +0200 Subject: [PATCH] Add feature toggle to enable dashbaord scene for viewers --- .../configure-grafana/feature-toggles/index.md | 1 + packages/grafana-data/src/types/featureToggles.gen.ts | 1 + pkg/services/featuremgmt/registry.go | 7 +++++++ pkg/services/featuremgmt/toggles_gen.csv | 1 + pkg/services/featuremgmt/toggles_gen.go | 4 ++++ 5 files changed, 14 insertions(+) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 38167a50e77..b693ec3c37f 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -151,6 +151,7 @@ Experimental features might be changed or removed without prior notice. | `awsDatasourcesNewFormStyling` | Applies new form styling for configuration and query editors in AWS plugins | | `cachingOptimizeSerializationMemoryUsage` | If enabled, the caching backend gradually serializes query responses for the cache, comparing against the configured `[caching]max_value_mb` value as it goes. This can can help prevent Grafana from running out of memory while attempting to cache very large query responses. | | `pluginsInstrumentationStatusSource` | Include a status source label for plugin request metrics and logs | +| `dashboardSceneForViewers` | Enables dashboard rendering using Scenes for viewer roles | ## Development feature toggles diff --git a/packages/grafana-data/src/types/featureToggles.gen.ts b/packages/grafana-data/src/types/featureToggles.gen.ts index 4aa882626d8..0b22f606b60 100644 --- a/packages/grafana-data/src/types/featureToggles.gen.ts +++ b/packages/grafana-data/src/types/featureToggles.gen.ts @@ -145,4 +145,5 @@ export interface FeatureToggles { cachingOptimizeSerializationMemoryUsage?: boolean; panelTitleSearchInV1?: boolean; pluginsInstrumentationStatusSource?: boolean; + dashboardSceneForViewers?: boolean; } diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 0d317cecab7..7f7a167b965 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -890,5 +890,12 @@ var ( Stage: FeatureStageExperimental, Owner: grafanaPluginsPlatformSquad, }, + { + Name: "dashboardSceneForViewers", + Description: "Enables dashboard rendering using Scenes for viewer roles", + Stage: FeatureStageExperimental, + FrontendOnly: true, + Owner: grafanaDashboardsSquad, + }, } ) diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index ca5e8ba18f6..574e144cbf0 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -126,3 +126,4 @@ awsDatasourcesNewFormStyling,experimental,@grafana/aws-datasources,false,false,f cachingOptimizeSerializationMemoryUsage,experimental,@grafana/grafana-operator-experience-squad,false,false,false,false panelTitleSearchInV1,experimental,@grafana/backend-platform,true,false,false,false pluginsInstrumentationStatusSource,experimental,@grafana/plugins-platform-backend,false,false,false,false +dashboardSceneForViewers,experimental,@grafana/dashboards-squad,false,false,false,true diff --git a/pkg/services/featuremgmt/toggles_gen.go b/pkg/services/featuremgmt/toggles_gen.go index 26931e0adda..9db732a05cd 100644 --- a/pkg/services/featuremgmt/toggles_gen.go +++ b/pkg/services/featuremgmt/toggles_gen.go @@ -514,4 +514,8 @@ const ( // FlagPluginsInstrumentationStatusSource // Include a status source label for plugin request metrics and logs FlagPluginsInstrumentationStatusSource = "pluginsInstrumentationStatusSource" + + // FlagDashboardSceneForViewers + // Enables dashboard rendering using Scenes for viewer roles + FlagDashboardSceneForViewers = "dashboardSceneForViewers" )