Alerting: Update Alert Rule to use int64 for MissingSeriesEvalsToResolve (#109306)
This commit is contained in:
@@ -661,7 +661,7 @@ func TestIntegrationProvisioningRules(t *testing.T) {
|
||||
Model: json.RawMessage([]byte(`{"type":"math","expression":"2 + 3 \u003e 1"}`)),
|
||||
},
|
||||
},
|
||||
MissingSeriesEvalsToResolve: util.Pointer(3),
|
||||
MissingSeriesEvalsToResolve: util.Pointer[int64](3),
|
||||
},
|
||||
},
|
||||
}
|
||||
@@ -676,7 +676,7 @@ func TestIntegrationProvisioningRules(t *testing.T) {
|
||||
for _, rule := range result.Rules {
|
||||
require.NotEmpty(t, rule.UID)
|
||||
if rule.UID == "rule3" {
|
||||
require.Equal(t, 3, *rule.MissingSeriesEvalsToResolve)
|
||||
require.Equal(t, int64(3), *rule.MissingSeriesEvalsToResolve)
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
@@ -1761,42 +1761,42 @@ func TestIntegrationRuleUpdate(t *testing.T) {
|
||||
t.Run("missing_series_evals_to_resolve", func(t *testing.T) {
|
||||
testCases := []struct {
|
||||
name string
|
||||
initialValue *int
|
||||
updatedValue *int
|
||||
expectedValue *int
|
||||
initialValue *int64
|
||||
updatedValue *int64
|
||||
expectedValue *int64
|
||||
expectedStatus int
|
||||
}{
|
||||
{
|
||||
name: "should be able to set missing_series_evals_to_resolve to 5",
|
||||
initialValue: nil,
|
||||
updatedValue: util.Pointer(5),
|
||||
expectedValue: util.Pointer(5),
|
||||
updatedValue: util.Pointer[int64](5),
|
||||
expectedValue: util.Pointer[int64](5),
|
||||
expectedStatus: http.StatusAccepted,
|
||||
},
|
||||
{
|
||||
name: "should be able to update missing_series_evals_to_resolve",
|
||||
initialValue: util.Pointer(1),
|
||||
updatedValue: util.Pointer(2),
|
||||
expectedValue: util.Pointer(2),
|
||||
initialValue: util.Pointer[int64](1),
|
||||
updatedValue: util.Pointer[int64](2),
|
||||
expectedValue: util.Pointer[int64](2),
|
||||
expectedStatus: http.StatusAccepted,
|
||||
},
|
||||
{
|
||||
name: "should preserve missing_series_evals_to_resolve when it's set nil",
|
||||
initialValue: util.Pointer(5),
|
||||
initialValue: util.Pointer[int64](5),
|
||||
updatedValue: nil,
|
||||
expectedValue: util.Pointer(5),
|
||||
expectedValue: util.Pointer[int64](5),
|
||||
expectedStatus: http.StatusAccepted,
|
||||
},
|
||||
{
|
||||
name: "should reject missing_series_evals_to_resolve < 0",
|
||||
initialValue: util.Pointer(1),
|
||||
updatedValue: util.Pointer(-1),
|
||||
initialValue: util.Pointer[int64](1),
|
||||
updatedValue: util.Pointer[int64](-1),
|
||||
expectedStatus: http.StatusBadRequest,
|
||||
},
|
||||
{
|
||||
name: "should be able to reset missing_series_evals_to_resolve by setting it to 0",
|
||||
initialValue: util.Pointer(1),
|
||||
updatedValue: util.Pointer(0),
|
||||
initialValue: util.Pointer[int64](1),
|
||||
updatedValue: util.Pointer[int64](0),
|
||||
expectedValue: nil,
|
||||
expectedStatus: http.StatusAccepted,
|
||||
},
|
||||
@@ -3474,7 +3474,7 @@ func TestIntegrationAlertRuleCRUD(t *testing.T) {
|
||||
},
|
||||
NoDataState: apimodels.NoDataState(ngmodels.Alerting),
|
||||
ExecErrState: apimodels.ExecutionErrorState(ngmodels.AlertingErrState),
|
||||
MissingSeriesEvalsToResolve: util.Pointer(2), // If UID is specified, this field is required
|
||||
MissingSeriesEvalsToResolve: util.Pointer[int64](2), // If UID is specified, this field is required
|
||||
},
|
||||
},
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user