From 172464e91e8024749875e6b3db3552c817d10164 Mon Sep 17 00:00:00 2001 From: Kyle Brandt Date: Mon, 22 Jul 2019 07:23:27 -0400 Subject: [PATCH] alerting: return err when SetAlertState fails to save to sql (#18216) fix duplicate alert states when the alert fails to save to the database. fixes #18176 --- pkg/services/sqlstore/alert.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/services/sqlstore/alert.go b/pkg/services/sqlstore/alert.go index 48096df7d57..50b4c4dd993 100644 --- a/pkg/services/sqlstore/alert.go +++ b/pkg/services/sqlstore/alert.go @@ -298,7 +298,10 @@ func SetAlertState(cmd *m.SetAlertStateCommand) error { alert.ExecutionError = cmd.Error } - sess.ID(alert.Id).Update(&alert) + _, err := sess.ID(alert.Id).Update(&alert) + if err != nil { + return err + } cmd.Result = alert return nil