From 17c03bed214dc61032069248614bef6c0cc07ab3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Mon, 11 Aug 2014 15:59:03 +0200 Subject: [PATCH] Added some unit tests for RowCtrl --- src/test/specs/helpers.js | 2 ++ src/test/specs/row-ctrl-specs.js | 62 ++++++++++++++++++++++++++++++++ src/test/test-main.js | 1 + 3 files changed, 65 insertions(+) create mode 100644 src/test/specs/row-ctrl-specs.js diff --git a/src/test/specs/helpers.js b/src/test/specs/helpers.js index f5c6a88d584..0383b69b5c0 100644 --- a/src/test/specs/helpers.js +++ b/src/test/specs/helpers.js @@ -24,7 +24,9 @@ define([ return inject(function($controller, $rootScope, $q) { self.scope = $rootScope.$new(); self.scope.panel = {}; + self.scope.row = { panels:[] }; self.scope.filter = new FilterSrvStub(); + $rootScope.colors = []; for (var i = 0; i < 50; i++) { $rootScope.colors.push('#' + i); } diff --git a/src/test/specs/row-ctrl-specs.js b/src/test/specs/row-ctrl-specs.js new file mode 100644 index 00000000000..de149b70fac --- /dev/null +++ b/src/test/specs/row-ctrl-specs.js @@ -0,0 +1,62 @@ +define([ + './helpers', + 'controllers/row' +], function(helpers) { + 'use strict'; + + describe('RowCtrl', function() { + var ctx = new helpers.ControllerTestContext(); + + beforeEach(module('grafana.controllers')); + + beforeEach(ctx.providePhase()); + beforeEach(ctx.createControllerPhase('RowCtrl')); + + describe('when getting rowSpan', function() { + it('should return sum of panels spans', function() { + var spanLeft = ctx.scope.rowSpan({ panels: [{ span: 2 }, { span: 3 }] }); + expect(spanLeft).to.be(5); + }); + }); + + describe('when adding panel to row with 12 span panel', function() { + it('should split span in half and add panel with defaults', function() { + ctx.scope.row = { panels: [{ span: 12 }] }; + ctx.scope.add_panel_default('graph'); + + expect(ctx.scope.row.panels[0].span).to.be(6); + expect(ctx.scope.row.panels[1].span).to.be(6); + expect(ctx.scope.row.panels[1].type).to.be('graph'); + }); + }); + + describe('when duplicating panel', function() { + it('should try to add it to same row', function() { + var panel = { span: 4, attr: '123' }; + ctx.scope.row = { panels: [panel] }; + ctx.scope.duplicatePanel(panel, ctx.scope.row); + + expect(ctx.scope.row.panels[0].span).to.be(4); + expect(ctx.scope.row.panels[1].span).to.be(4); + expect(ctx.scope.row.panels[1].attr).to.be('123'); + }); + }); + + describe('when duplicating panel', function() { + it('should add row if there is no space left', function() { + var panel = { span: 12, attr: '123' }; + ctx.scope.row = { panels: [panel] }; + ctx.scope.dashboard = { rows: [ctx.scope.row] }; + + ctx.scope.duplicatePanel(panel, ctx.scope.row); + + expect(ctx.scope.row.panels[0].span).to.be(12); + expect(ctx.scope.row.panels.length).to.be(1); + expect(ctx.scope.dashboard.rows[1].panels[0].attr).to.be('123'); + }); + }); + + }); + +}); + diff --git a/src/test/test-main.js b/src/test/test-main.js index c41fa80ad6e..4f30ef7910e 100644 --- a/src/test/test-main.js +++ b/src/test/test-main.js @@ -117,6 +117,7 @@ require([ 'specs/lexer-specs', 'specs/parser-specs', 'specs/gfunc-specs', + 'specs/row-ctrl-specs', 'specs/graphiteTargetCtrl-specs', 'specs/influxdb-datasource-specs', 'specs/graph-ctrl-specs',