diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 116beb08daf..5b3d337cb1a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -42,9 +42,11 @@ Usage: "Fixes #", or "Fixes (paste link of issue)" Fixes # -**Special notes for your reviewer:** +**Checklist:** + +Both author and reviewer should ensure the following: -Please check that: - [ ] It works as expected from a user's perspective. - [ ] If this is a pre-GA feature, it is behind a feature toggle. - [ ] The docs are updated, and if this is a [notable improvement](https://grafana.com/docs/writers-toolkit/contribute/release-notes/#how-to-determine-if-content-belongs-in-whats-new), it's added to our [What's New](https://grafana.com/docs/writers-toolkit/contribute/release-notes/) doc. +- [ ] Tests are added and passing, both for new functionality and for any bug fixes.