From 18269dae07540f0c592dafeae584815d3f0da1d0 Mon Sep 17 00:00:00 2001 From: Sam Jewell Date: Mon, 12 Jan 2026 15:32:58 +0000 Subject: [PATCH] GitHub: Add tests checkbox to PR template checklist Adds an explicit reminder for both authors and reviewers to ensure tests are added and passing for new functionality and bug fixes. Also renames the section from "Special notes for your reviewer" to "Checklist" with shared accountability framing. --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 116beb08daf..5b3d337cb1a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -42,9 +42,11 @@ Usage: "Fixes #", or "Fixes (paste link of issue)" Fixes # -**Special notes for your reviewer:** +**Checklist:** + +Both author and reviewer should ensure the following: -Please check that: - [ ] It works as expected from a user's perspective. - [ ] If this is a pre-GA feature, it is behind a feature toggle. - [ ] The docs are updated, and if this is a [notable improvement](https://grafana.com/docs/writers-toolkit/contribute/release-notes/#how-to-determine-if-content-belongs-in-whats-new), it's added to our [What's New](https://grafana.com/docs/writers-toolkit/contribute/release-notes/) doc. +- [ ] Tests are added and passing, both for new functionality and for any bug fixes.