Storage: support git + github backed roots (#52192)

pkg/services/store/tree.go

@@ -2,6 +2,7 @@ package store
 
 import (
 	"context"
+	"fmt"
 	"sync"
 
 	"github.com/grafana/grafana-plugin-sdk-go/data"
@@ -77,12 +78,15 @@ func (t *nestedTree) GetFile(ctx context.Context, orgId int64, path string) (*fi
 	if path == "" {
 		return nil, nil // not found
 	}
-
 	root, path := t.getRoot(orgId, path)
 	if root == nil {
 		return nil, nil // not found (or not ready)
 	}
-	return root.Store().Get(ctx, path)
+	store := root.Store()
+	if store == nil {
+		return nil, fmt.Errorf("store not ready")
+	}
+	return store.Get(ctx, path)
 }
 
 func (t *nestedTree) ListFolder(ctx context.Context, orgId int64, path string, accessFilter filestorage.PathFilter) (*StorageListFrame, error) {
@@ -98,26 +102,17 @@ func (t *nestedTree) ListFolder(ctx context.Context, orgId int64, path string, a
 		names := data.NewFieldFromFieldType(data.FieldTypeString, count)
 		title := data.NewFieldFromFieldType(data.FieldTypeString, count)
 		descr := data.NewFieldFromFieldType(data.FieldTypeString, count)
-		types := data.NewFieldFromFieldType(data.FieldTypeString, count)
-		readOnly := data.NewFieldFromFieldType(data.FieldTypeBool, count)
-		builtIn := data.NewFieldFromFieldType(data.FieldTypeBool, count)
 		mtype := data.NewFieldFromFieldType(data.FieldTypeString, count)
 		title.Name = titleListFrameField
 		names.Name = nameListFrameField
 		descr.Name = descriptionListFrameField
 		mtype.Name = mediaTypeListFrameField
-		types.Name = storageTypeListFrameField
-		readOnly.Name = readOnlyListFrameField
-		builtIn.Name = builtInListFrameField
 		for _, f := range t.rootsByOrgId[ac.GlobalOrgID] {
 			meta := f.Meta()
 			names.Set(idx, meta.Config.Prefix)
 			title.Set(idx, meta.Config.Name)
 			descr.Set(idx, meta.Config.Description)
 			mtype.Set(idx, "directory")
-			types.Set(idx, meta.Config.Type)
-			readOnly.Set(idx, meta.ReadOnly)
-			builtIn.Set(idx, meta.Builtin)
 			idx++
 		}
 		if orgId != ac.GlobalOrgID {
@@ -127,14 +122,11 @@ func (t *nestedTree) ListFolder(ctx context.Context, orgId int64, path string, a
 				title.Set(idx, meta.Config.Name)
 				descr.Set(idx, meta.Config.Description)
 				mtype.Set(idx, "directory")
-				types.Set(idx, meta.Config.Type)
-				readOnly.Set(idx, meta.ReadOnly)
-				builtIn.Set(idx, meta.Builtin)
 				idx++
 			}
 		}
 
-		frame := data.NewFrame("", names, title, descr, mtype, types, readOnly, builtIn)
+		frame := data.NewFrame("", names, title, descr, mtype)
 		frame.SetMeta(&data.FrameMeta{
 			Type: data.FrameTypeDirectoryListing,
 		})
@@ -146,7 +138,12 @@ func (t *nestedTree) ListFolder(ctx context.Context, orgId int64, path string, a
 		return nil, nil // not found (or not ready)
 	}
 
-	listResponse, err := root.Store().List(ctx, path, nil, &filestorage.ListOptions{
+	store := root.Store()
+	if store == nil {
+		return nil, fmt.Errorf("store not ready")
+	}
+
+	listResponse, err := store.List(ctx, path, nil, &filestorage.ListOptions{
 		Recursive:   false,
 		WithFolders: true,
 		WithFiles:   true,