From 1aefc4cc2d47df02d4bd71ba53493cbcc4288664 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hugo=20H=C3=A4ggmark?= <hugo.haggmark@gmail.com>
Date: Tue, 22 Jan 2019 14:50:19 +0100
Subject: [PATCH] Refactored out ExploreToolbar from Explore

---
 public/app/features/explore/Explore.tsx       |  69 +++---------
 .../app/features/explore/ExploreToolbar.tsx   | 100 ++++++++++++++++++
 2 files changed, 116 insertions(+), 53 deletions(-)
 create mode 100644 public/app/features/explore/ExploreToolbar.tsx

diff --git a/public/app/features/explore/Explore.tsx b/public/app/features/explore/Explore.tsx
index b6f57a76004..25d868e3565 100644
--- a/public/app/features/explore/Explore.tsx
+++ b/public/app/features/explore/Explore.tsx
@@ -10,7 +10,6 @@ import store from 'app/core/store';
 
 // Components
 import { DataSourceSelectItem } from '@grafana/ui/src/types';
-import { DataSourcePicker } from 'app/core/components/Select/DataSourcePicker';
 import { Alert } from './Error';
 import ErrorBoundary from './ErrorBoundary';
 import GraphContainer from './GraphContainer';
@@ -41,6 +40,7 @@ import { ExploreItemState, ExploreUrlState, RangeScanner, ExploreId } from 'app/
 import { StoreState } from 'app/types';
 import { LAST_USED_DATASOURCE_KEY, ensureQueries, DEFAULT_RANGE } from 'app/core/utils/explore';
 import { Emitter } from 'app/core/utils/emitter';
+import { ExploreToolbar } from './ExploreToolbar';
 
 interface ExploreProps {
   StartPage?: any;
@@ -233,58 +233,21 @@ export class Explore extends React.PureComponent<ExploreProps> {
 
     return (
       <div className={exploreClass} ref={this.getRef}>
-        <div className="navbar">
-          {exploreId === 'left' ? (
-            <div>
-              <a className="navbar-page-btn">
-                <i className="fa fa-rocket" />
-                Explore
-              </a>
-            </div>
-          ) : (
-            <>
-              <div className="navbar-page-btn" />
-              <div className="navbar-buttons explore-first-button">
-                <button className="btn navbar-button" onClick={this.onClickCloseSplit}>
-                  Close Split
-                </button>
-              </div>
-            </>
-          )}
-          {!datasourceMissing ? (
-            <div className="navbar-buttons">
-              <DataSourcePicker
-                onChange={this.onChangeDatasource}
-                datasources={exploreDatasources}
-                current={selectedDatasource}
-              />
-            </div>
-          ) : null}
-          <div className="navbar__spacer" />
-          {exploreId === 'left' && !split ? (
-            <div className="navbar-buttons">
-              <button className="btn navbar-button" onClick={this.onClickSplit}>
-                Split
-              </button>
-            </div>
-          ) : null}
-          <TimePicker ref={this.timepickerRef} range={range} onChangeTime={this.onChangeTime} />
-          <div className="navbar-buttons">
-            <button className="btn navbar-button navbar-button--no-icon" onClick={this.onClickClear}>
-              Clear All
-            </button>
-          </div>
-          <div className="navbar-buttons relative">
-            <button className="btn navbar-button navbar-button--primary" onClick={this.onSubmit}>
-              Run Query{' '}
-              {loading ? (
-                <i className="fa fa-spinner fa-fw fa-spin run-icon" />
-              ) : (
-                <i className="fa fa-level-down fa-fw run-icon" />
-              )}
-            </button>
-          </div>
-        </div>
+        <ExploreToolbar
+          datasourceMissing={datasourceMissing}
+          exploreDatasources={exploreDatasources}
+          exploreId={exploreId}
+          loading={loading}
+          range={range}
+          selectedDatasource={selectedDatasource}
+          splitted={split}
+          onChangeDatasource={this.onChangeDatasource}
+          onClearAll={this.onClickClear}
+          onCloseSplit={this.onClickCloseSplit}
+          onChangeTime={this.onChangeTime}
+          onRunQuery={this.onSubmit}
+          onSplit={this.onClickSplit}
+        />
         {datasourceLoading ? <div className="explore-container">Loading datasource...</div> : null}
         {datasourceMissing ? (
           <div className="explore-container">Please add a datasource that supports Explore (e.g., Prometheus).</div>
diff --git a/public/app/features/explore/ExploreToolbar.tsx b/public/app/features/explore/ExploreToolbar.tsx
new file mode 100644
index 00000000000..6b25b367039
--- /dev/null
+++ b/public/app/features/explore/ExploreToolbar.tsx
@@ -0,0 +1,100 @@
+import React, { PureComponent } from 'react';
+import { ExploreId } from 'app/types/explore';
+import { DataSourcePicker } from 'app/core/components/Select/DataSourcePicker';
+import { DataSourceSelectItem, RawTimeRange, TimeRange } from '@grafana/ui';
+import TimePicker from './TimePicker';
+
+interface Props {
+  datasourceMissing: boolean;
+  exploreDatasources: DataSourceSelectItem[];
+  exploreId: ExploreId;
+  loading: boolean;
+  range: RawTimeRange;
+  selectedDatasource: DataSourceSelectItem;
+  splitted: boolean;
+  onChangeDatasource: (option) => void;
+  onClearAll: () => void;
+  onCloseSplit: () => void;
+  onChangeTime: (range: TimeRange, changedByScanner?: boolean) => void;
+  onRunQuery: () => void;
+  onSplit: () => void;
+}
+
+export class ExploreToolbar extends PureComponent<Props, {}> {
+  /**
+   * Timepicker to control scanning
+   */
+  timepickerRef: React.RefObject<TimePicker>;
+
+  constructor(props) {
+    super(props);
+    this.timepickerRef = React.createRef();
+  }
+
+  render() {
+    const {
+      datasourceMissing,
+      exploreDatasources,
+      exploreId,
+      loading,
+      range,
+      selectedDatasource,
+      splitted,
+    } = this.props;
+
+    return (
+      <div className="navbar">
+        {exploreId === 'left' ? (
+          <div>
+            <a className="navbar-page-btn">
+              <i className="fa fa-rocket" />
+              Explore
+            </a>
+          </div>
+        ) : (
+          <>
+            <div className="navbar-page-btn" />
+            <div className="navbar-buttons explore-first-button">
+              <button className="btn navbar-button" onClick={this.props.onCloseSplit}>
+                Close Split
+              </button>
+            </div>
+          </>
+        )}
+        {!datasourceMissing ? (
+          <div className="navbar-buttons">
+            <DataSourcePicker
+              onChange={this.props.onChangeDatasource}
+              datasources={exploreDatasources}
+              current={selectedDatasource}
+            />
+          </div>
+        ) : null}
+        <div className="navbar__spacer" />
+        {exploreId === 'left' && !splitted ? (
+          <div className="navbar-buttons">
+            <button className="btn navbar-button" onClick={this.props.onSplit}>
+              Split
+            </button>
+          </div>
+        ) : null}
+        <TimePicker ref={this.timepickerRef} range={range} onChangeTime={this.props.onChangeTime} />
+        <div className="navbar-buttons">
+          <button className="btn navbar-button navbar-button--no-icon" onClick={this.props.onClearAll}>
+            Clear All
+          </button>
+        </div>
+        <div className="navbar-buttons relative">
+          <button className="btn navbar-button navbar-button--primary" onClick={this.props.onRunQuery}>
+            Run Query{' '}
+            {loading ? (
+              <i className="fa fa-spinner fa-fw fa-spin run-icon" />
+            ) : (
+              <i className="fa fa-level-down fa-fw run-icon" />
+            )}
+          </button>
+        </div>
+      </div>
+    );
+  }
+}