Provisioning finalisers fix 2 (#111679)

* adding some logs to better understand what might be happening

* only focus this PR on improve logging in finalizer handling

* debug log before calling finalizers

* working on finalizers

* removing last todos, adding unit tests

* better use SupportedFinalizers name

* addressing comments

* wip: fix tests and add delete error in status

* chore: codegen

* chore: codegen openapi

* Merge remote-tracking branch 'origin/main' into provisioning-finalisers-fix-2

* update frontend client

* fix: errors in testing

* fix: breaking test

---------

Co-authored-by: Daniele Ferru <daniele.ferru@grafana.com>
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>

apps/provisioning/pkg/repository/github/webhook.go

@@ -273,9 +273,14 @@ func (r *githubWebhookRepository) deleteWebhook(ctx context.Context) error {
 
 	id := r.config.Status.Webhook.ID
 
-	if err := r.gh.DeleteWebhook(ctx, r.owner, r.repo, id); err != nil {
+	err := r.gh.DeleteWebhook(ctx, r.owner, r.repo, id)
+	if err != nil && !errors.Is(err, ErrResourceNotFound) {
 		return fmt.Errorf("delete webhook: %w", err)
 	}
+	if errors.Is(err, ErrResourceNotFound) {
+		logger.Info("webhook does not exist", "url", r.config.Status.Webhook.URL, "id", id)
+		return nil
+	}
 
 	logger.Info("webhook deleted", "url", r.config.Status.Webhook.URL, "id", id)
 	return nil

apps/provisioning/pkg/repository/github/webhook_test.go

@@ -1539,6 +1539,32 @@ func TestGitHubRepository_OnDelete(t *testing.T) {
 			webhookURL:    "https://example.com/webhook",
 			expectedError: nil,
 		},
+		{
+			name: "webhook not found during deletion",
+			setupMock: func(m *MockClient) {
+				m.On("DeleteWebhook", mock.Anything, "grafana", "grafana", int64(123)).
+					Return(ErrResourceNotFound)
+			},
+			config: &provisioning.Repository{
+				ObjectMeta: metav1.ObjectMeta{
+					Name: "test-repo",
+				},
+				Spec: provisioning.RepositorySpec{
+					GitHub: &provisioning.GitHubRepositoryConfig{
+						Branch: "main",
+					},
+				},
+				Status: provisioning.RepositoryStatus{
+					Webhook: &provisioning.WebhookStatus{
+						ID:  123,
+						URL: "https://example.com/webhook",
+					},
+				},
+			},
+			webhookURL: "https://example.com/webhook",
+			// We don't return an error if the webhook is already gone
+			expectedError: nil,
+		},
 		{
 			name:      "no webhook URL provided",
 			setupMock: func(_ *MockClient) {},