Chore: Fix flaky cloud migration test (#94035)

* attempt to fix flaky test

* remove skip from test
This commit is contained in:
Michael Mandrus
2024-09-30 22:24:47 -04:00
committed by GitHub
parent 0c1aafd643
commit 1c648fd010
4 changed files with 7 additions and 8 deletions
@@ -617,7 +617,7 @@ func setUpServiceTest(t *testing.T, withDashboardMock bool) cloudmigration.Servi
featuremgmt.FlagDashboardRestore),
sqlStore,
dsService,
secretskv.NewFakeSQLSecretsKVStore(t),
secretskv.NewFakeSQLSecretsKVStore(t, sqlStore),
secretsService,
rr,
prometheus.DefaultRegisterer,
@@ -228,8 +228,6 @@ func Test_SnapshotResources(t *testing.T) {
}
func TestGetSnapshotList(t *testing.T) {
t.Skip("FLAKY test: disabled until fixed")
_, s := setUpTest(t)
// Taken from setUpTest
sessionUID := "qwerty"
@@ -322,7 +320,7 @@ func setUpTest(t *testing.T) (*sqlstore.SQLStore, *sqlStore) {
s := &sqlStore{
db: testDB,
secretsService: fakeSecrets.FakeSecretsService{},
secretsStore: secretskv.NewFakeSQLSecretsKVStore(t),
secretsStore: secretskv.NewFakeSQLSecretsKVStore(t, testDB),
}
ctx := context.Background()