public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #13530 from grafana/davkal/13485-cursor-suggestions

Browse Source 
Explore: reset typeahead on cursor move
This commit is contained in:
Torkel Ödegaard
2018-10-04 18:05:32 +02:00
committed by GitHub
parent 5aa91fc1c5 a0b21db053
commit 1da352822a
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/explore/QueryField.tsx
+9 -3
View File
@@ -179,15 +179,21 @@ class QueryField extends React.PureComponent<TypeaheadFieldProps, TypeaheadField
} }
onChange = ({ value }) => { onChange = ({ value }) => {
const changed = value.document !== this.state.value.document; const textChanged = value.document !== this.state.value.document;
// Control editor loop, then pass text change up to parent
this.setState({ value }, () => { this.setState({ value }, () => {
if (changed) { if (textChanged) {
this.handleChangeValue(); this.handleChangeValue();
} }
}); });
if (changed) { // Show suggest menu on text input
if (textChanged && value.selection.isCollapsed) {
// Need one paint to allow DOM-based typeahead rules to work
window.requestAnimationFrame(this.handleTypeahead); window.requestAnimationFrame(this.handleTypeahead);
} else {
this.resetTypeahead();
} }
}; };