public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve component performance

Browse Source
This commit is contained in:
Erik Sundell
2019-01-07 11:26:05 +01:00
parent 86a39183ee
commit 1e5f2f56e0
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/plugins/datasource/stackdriver/components/StackdriverPicker.tsx
+2 -7
View File
@@ -40,11 +40,8 @@ export class StackdriverPicker extends React.Component<Props, State> {
} }
shouldComponentUpdate(nextProps: Props) { shouldComponentUpdate(nextProps: Props) {
return ( const nextOptions = this.buildOptions(nextProps);
nextProps.selected !== this.props.selected || return nextProps.selected !== this.props.selected || !_.isEqual(nextOptions, this.state.options);
!_.isEqual(nextProps.options, this.props.options) ||
!_.isEqual(nextProps.templateVariables, this.props.templateVariables)
);
} }
buildOptions({ templateVariables = [], groupName = '', options }) { buildOptions({ templateVariables = [], groupName = '', options }) {
@@ -89,9 +86,7 @@ export class StackdriverPicker extends React.Component<Props, State> {
backspaceRemovesValue={false} backspaceRemovesValue={false}
onChange={item => onChange(item.value)} onChange={item => onChange(item.value)}
options={options} options={options}
autoFocus={false}
isSearchable={searchable} isSearchable={searchable}
openMenuOnFocus={true}
maxMenuHeight={500} maxMenuHeight={500}
placeholder={placeholder} placeholder={placeholder}
noOptionsMessage={() => 'No options found'} noOptionsMessage={() => 'No options found'}