public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pipeline: Fix flakiness on Pa11y CI (#39358)

Browse Source 
* Pipeline: Add wait prop into pa11y configuration for all the pages

* Pa11y: Use e2e instance to generate html report local environment

* Pipeline: use pa11y-ci hash commit

* Pipeline: Update Pa11y thresholds

* Update package.json

* Update yarn.lock

Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
This commit is contained in:
Maria Alexandra
2021-09-23 15:02:30 +02:00
committed by GitHub
co-authored by Leon Sorokin
parent 1865689411
commit 1e946316e0
9 changed files with 266 additions and 153 deletions
Download Patch File Download Diff File Expand all files Collapse all files
contribute/create-pull-request.md
+1 -1
View File
@@ -62,7 +62,7 @@ We use [pa11y-ci](https://github.com/pa11y/pa11y-ci) to collect accessibility er
If the contribution introduces new a11y errors, our continuous integration will fail, preventing you to merge on the main branch. In those cases there are two alternatives for moving forward:
- Check the error log on the pipeline step `test-a11y-frontend-pr`, identify what was the error, and fix it.
- Locally run the command `yarn test:accessibility-report` that generates an HTML accessibility report, then go to the URL that contains your change, identify the error, and fix it. Keep in mind, a local Grafana instance needs to be running on `http://localhost:3000`.
- Locally run the command `yarn test:accessibility-report` that generates an HTML accessibility report, then go to the URL that contains your change, identify the error, and fix it. Keep in mind, a local e2e Grafana instance is going to be running on `http://localhost:3001`.
You can also prevent introducing a11y errors by installing an a11y plugin in your browser, for example, axe DevTools, Accessibility Insights for Web among others.