Provisioning: Improve sample provisioning (#103508)

pkg/registry/apis/provisioning/resources/parser_test.go

@@ -2,14 +2,14 @@ package resources
 
 import (
 	"context"
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
 
 	dashboardV0 "github.com/grafana/grafana/apps/dashboard/pkg/apis/dashboard/v0alpha1"
 	dashboardV1 "github.com/grafana/grafana/apps/dashboard/pkg/apis/dashboard/v1alpha1"
-
-	"github.com/grafana/grafana/pkg/apis/provisioning/v0alpha1"
+	provisioning "github.com/grafana/grafana/pkg/apis/provisioning/v0alpha1"
 	"github.com/grafana/grafana/pkg/registry/apis/provisioning/repository"
 )
 
@@ -21,8 +21,8 @@ func TestParser(t *testing.T) {
 		Return(nil, dashboardV1.DashboardResourceInfo.GroupVersionResource(), nil).Maybe()
 
 	parser := &parser{
-		repo: v0alpha1.ResourceRepositoryInfo{
-			Type:      v0alpha1.LocalRepositoryType,
+		repo: provisioning.ResourceRepositoryInfo{
+			Type:      provisioning.LocalRepositoryType,
 			Namespace: "xxx",
 			Name:      "repo",
 		},
@@ -63,13 +63,34 @@ spec:
 `),
 		})
 		require.EqualError(t, err, "name.metadata.name: Required value: missing name in resource")
+	})
 
-		// Read the name from classic grafana format
-		dash, err = parser.Parse(context.Background(), &repository.FileInfo{
+	t.Run("generate name will generate a name", func(t *testing.T) {
+		dash, err := parser.Parse(context.Background(), &repository.FileInfo{
+			Data: []byte(`apiVersion: dashboard.grafana.app/v0alpha1
+kind: Dashboard
+metadata:
+  generateName: rand-
+spec:
+  title: Test dashboard
+`),
+		})
+		require.NoError(t, err)
+		require.Equal(t, "dashboard.grafana.app", dash.GVK.Group)
+		require.Equal(t, "v0alpha1", dash.GVK.Version)
+		require.True(t, strings.HasPrefix(dash.Obj.GetName(), "rand-"), "set name")
+	})
+
+	t.Run("dashboard classic format", func(t *testing.T) {
+		dash, err := parser.Parse(context.Background(), &repository.FileInfo{
 			Data: []byte(`{ "uid": "test", "schemaVersion": 30, "panels": [], "tags": [] }`),
 		})
 		require.NoError(t, err)
-		require.Equal(t, v0alpha1.ClassicDashboard, dash.Classic)
 		require.Equal(t, "test", dash.Obj.GetName())
+		require.Equal(t, provisioning.ClassicDashboard, dash.Classic)
+		require.Equal(t, "dashboard.grafana.app", dash.GVK.Group)
+		require.Equal(t, "v0alpha1", dash.GVK.Version)
+		require.Equal(t, "dashboard.grafana.app", dash.GVR.Group)
+		require.Equal(t, "v0alpha1", dash.GVR.Version)
 	})
 }