Forms: Remove gf-form from BasicSettings.tsx (#112310)

This commit is contained in:
Dan83
2025-10-21 15:50:56 -06:00
committed by GitHub
parent 069cc909ea
commit 1ffe3cc486
2 changed files with 8 additions and 13 deletions
-5
View File
@@ -2852,11 +2852,6 @@
"count": 2 "count": 2
} }
}, },
"public/app/features/datasources/components/BasicSettings.tsx": {
"no-restricted-syntax": {
"count": 3
}
},
"public/app/features/datasources/components/ButtonRow.tsx": { "public/app/features/datasources/components/ButtonRow.tsx": {
"no-restricted-syntax": { "no-restricted-syntax": {
"count": 1 "count": 1
@@ -4,7 +4,7 @@ import * as React from 'react';
import { GrafanaTheme2 } from '@grafana/data'; import { GrafanaTheme2 } from '@grafana/data';
import { selectors } from '@grafana/e2e-selectors'; import { selectors } from '@grafana/e2e-selectors';
import { t } from '@grafana/i18n'; import { t } from '@grafana/i18n';
import { InlineField, InlineSwitch, Input, Badge, useStyles2 } from '@grafana/ui'; import { InlineField, InlineSwitch, Input, Badge, useStyles2, Box, Stack } from '@grafana/ui';
export interface Props { export interface Props {
dataSourceName: string; dataSourceName: string;
@@ -17,16 +17,16 @@ export interface Props {
export function BasicSettings({ dataSourceName, isDefault, onDefaultChange, onNameChange, disabled }: Props) { export function BasicSettings({ dataSourceName, isDefault, onDefaultChange, onNameChange, disabled }: Props) {
return ( return (
<> <>
<div <Box
className="gf-form-group" marginBottom={5}
aria-label={t( aria-label={t(
'datasources.basic-settings.aria-label-datasource-settings-page-basic', 'datasources.basic-settings.aria-label-datasource-settings-page-basic',
'Datasource settings page basic settings' 'Datasource settings page basic settings'
)} )}
> >
<div className="gf-form-inline"> <Stack direction="row" wrap alignItems="flex-start" justifyContent="start" gap={0}>
{/* Name */} {/* Name */}
<div className="gf-form max-width-30"> <Box width={64}>
<InlineField <InlineField
label={t('datasources.basic-settings.label-name', 'Name')} label={t('datasources.basic-settings.label-name', 'Name')}
tooltip={t( tooltip={t(
@@ -47,7 +47,7 @@ export function BasicSettings({ dataSourceName, isDefault, onDefaultChange, onNa
data-testid={selectors.pages.DataSource.name} data-testid={selectors.pages.DataSource.name}
/> />
</InlineField> </InlineField>
</div> </Box>
{/* Is Default */} {/* Is Default */}
<InlineField <InlineField
@@ -63,8 +63,8 @@ export function BasicSettings({ dataSourceName, isDefault, onDefaultChange, onNa
}} }}
/> />
</InlineField> </InlineField>
</div> </Stack>
</div> </Box>
</> </>
); );
} }