From 21200fd5f84966353aeebf23d1bc00525f5056a4 Mon Sep 17 00:00:00 2001
From: Ashley Harrison <ashley.harrison@grafana.com>
Date: Mon, 15 Jan 2024 09:43:53 +0000
Subject: [PATCH] Chore: Mock out faro so this test doesn't throw an error
 (#80477)

mock out faro for all tests
---
 .../GrafanaJavascriptAgentBackend.test.ts     | 81 ++++++++++---------
 1 file changed, 43 insertions(+), 38 deletions(-)

diff --git a/public/app/core/services/echo/backends/grafana-javascript-agent/GrafanaJavascriptAgentBackend.test.ts b/public/app/core/services/echo/backends/grafana-javascript-agent/GrafanaJavascriptAgentBackend.test.ts
index dfb6d424324..e1f19cd6a85 100644
--- a/public/app/core/services/echo/backends/grafana-javascript-agent/GrafanaJavascriptAgentBackend.test.ts
+++ b/public/app/core/services/echo/backends/grafana-javascript-agent/GrafanaJavascriptAgentBackend.test.ts
@@ -1,16 +1,50 @@
 import { BuildInfo } from '@grafana/data';
 import { GrafanaEdition } from '@grafana/data/src/types/config';
-import { Instrumentation } from '@grafana/faro-core';
+import { Faro, Instrumentation } from '@grafana/faro-core';
 import * as faroWebSdkModule from '@grafana/faro-web-sdk';
-import { FetchTransport, initializeFaro } from '@grafana/faro-web-sdk';
+import { BrowserConfig, FetchTransport } from '@grafana/faro-web-sdk';
 
 import { EchoSrvTransport } from './EchoSrvTransport';
 import { GrafanaJavascriptAgentBackend, GrafanaJavascriptAgentBackendOptions } from './GrafanaJavascriptAgentBackend';
 
 describe('GrafanaJavascriptAgentEchoBackend', () => {
+  let mockedSetUser: jest.Mock;
+  let initializeFaroMock: jest.SpyInstance<Faro, [config: BrowserConfig]>;
+
   beforeEach(() => {
+    // arrange
+    mockedSetUser = jest.fn();
+    const mockedInstrumentationsForConfig: Instrumentation[] = [];
+    const mockedInstrumentations = {
+      add: jest.fn(),
+      instrumentations: mockedInstrumentationsForConfig,
+      remove: jest.fn(),
+    };
+    const mockedInternalLogger = {
+      prefix: 'Faro',
+      debug: jest.fn(),
+      info: jest.fn(),
+      warn: jest.fn(),
+      error: jest.fn(),
+    };
+
+    initializeFaroMock = jest.spyOn(faroWebSdkModule, 'initializeFaro').mockReturnValueOnce({
+      ...faroWebSdkModule.faro,
+      api: {
+        ...faroWebSdkModule.faro.api,
+        setUser: mockedSetUser,
+      },
+      config: {
+        ...faroWebSdkModule.faro.config,
+        instrumentations: mockedInstrumentationsForConfig,
+      },
+      instrumentations: mockedInstrumentations,
+      internalLogger: mockedInternalLogger,
+    });
+  });
+
+  afterEach(() => {
     jest.resetAllMocks();
-    window.fetch = jest.fn();
     jest.resetModules();
     jest.clearAllMocks();
   });
@@ -50,47 +84,18 @@ describe('GrafanaJavascriptAgentEchoBackend', () => {
 
     //assert
     expect(constructorSpy).toHaveBeenCalledTimes(1);
-    expect(faroWebSdkModule.faro.transports.transports.length).toEqual(2);
-    expect(faroWebSdkModule.faro.transports.transports[0]).toBeInstanceOf(EchoSrvTransport);
-    expect(faroWebSdkModule.faro.transports.transports[1]).toBeInstanceOf(FetchTransport);
+    expect(initializeFaroMock).toHaveBeenCalledTimes(1);
+    expect(initializeFaroMock.mock.calls[0][0].transports?.length).toEqual(2);
+    expect(initializeFaroMock.mock.calls[0][0].transports?.[0]).toBeInstanceOf(EchoSrvTransport);
+    expect(initializeFaroMock.mock.calls[0][0].transports?.[1]).toBeInstanceOf(FetchTransport);
   });
 
-  it('will initialize GrafanaJavascriptAgent and set user', () => {
-    // arrange
-    const mockedSetUser = jest.fn();
-    const mockedInstrumentationsForConfig: Instrumentation[] = [];
-    const mockedInstrumentations = {
-      add: jest.fn(),
-      instrumentations: mockedInstrumentationsForConfig,
-      remove: jest.fn(),
-    };
-    const mockedInternalLogger = {
-      prefix: 'Faro',
-      debug: jest.fn(),
-      info: jest.fn(),
-      warn: jest.fn(),
-      error: jest.fn(),
-    };
-
-    jest.spyOn(faroWebSdkModule, 'initializeFaro').mockReturnValueOnce({
-      ...faroWebSdkModule.faro,
-      api: {
-        ...faroWebSdkModule.faro.api,
-        setUser: mockedSetUser,
-      },
-      config: {
-        ...faroWebSdkModule.faro.config,
-        instrumentations: mockedInstrumentationsForConfig,
-      },
-      instrumentations: mockedInstrumentations,
-      internalLogger: mockedInternalLogger,
-    });
-
+  it('will initialize GrafanaJavascriptAgent and set user', async () => {
     //act
     new GrafanaJavascriptAgentBackend(options);
 
     //assert
-    expect(initializeFaro).toHaveBeenCalledTimes(1);
+    expect(initializeFaroMock).toHaveBeenCalledTimes(1);
     expect(mockedSetUser).toHaveBeenCalledTimes(1);
     expect(mockedSetUser).toHaveBeenCalledWith({
       id: '504',