Plugins: Tidy config struct (#84168)

* tidy plugins config usage

* fix tests

pkg/plugins/manager/loader/assetpath/assetpath_test.go

@@ -124,46 +124,4 @@ func TestService(t *testing.T) {
 			})
 		})
 	}
-
-	t.Run("App Sub URL has no effect on the path", func(t *testing.T) {
-		for _, tc := range []struct {
-			appSubURL string
-		}{
-			{
-				appSubURL: "grafana",
-			},
-			{
-				appSubURL: "/grafana",
-			},
-			{
-				appSubURL: "grafana/",
-			},
-			{
-				appSubURL: "/grafana/",
-			},
-		} {
-			cfg := &config.PluginManagementCfg{GrafanaAppSubURL: tc.appSubURL}
-			svc := ProvideService(cfg, pluginscdn.ProvideService(cfg))
-
-			dir := "/plugins/test-datasource"
-			p := plugins.JSONData{ID: "test-datasource"}
-			fs := fakes.NewFakePluginFiles(dir)
-
-			base, err := svc.Base(NewPluginInfo(p, plugins.ClassExternal, fs))
-			require.NoError(t, err)
-			require.Equal(t, "public/plugins/test-datasource", base)
-
-			mod, err := svc.Module(NewPluginInfo(p, plugins.ClassExternal, fs))
-			require.NoError(t, err)
-			require.Equal(t, "public/plugins/test-datasource/module.js", mod)
-
-			base, err = svc.Base(NewPluginInfo(p, plugins.ClassCore, fs))
-			require.NoError(t, err)
-			require.Equal(t, "public/app/plugins/test-datasource", base)
-
-			mod, err = svc.Module(NewPluginInfo(p, plugins.ClassCore, fs))
-			require.NoError(t, err)
-			require.Equal(t, "core:plugin/test-datasource", mod)
-		}
-	})
 }

pkg/plugins/manager/loader/loader_test.go

@@ -410,47 +410,6 @@ func TestLoader_Load(t *testing.T) {
 				},
 			},
 		},
-		{
-			name:  "Load a plugin with app sub url set",
-			class: plugins.ClassExternal,
-			cfg: &config.PluginManagementCfg{
-				DevMode:          true,
-				GrafanaAppSubURL: "grafana",
-				Features:         featuremgmt.WithFeatures(),
-			},
-			pluginPaths: []string{"../testdata/unsigned-datasource"},
-			want: []*plugins.Plugin{
-				{
-					JSONData: plugins.JSONData{
-						ID:   "test-datasource",
-						Type: plugins.TypeDataSource,
-						Name: "Test",
-						Info: plugins.Info{
-							Author: plugins.InfoLink{
-								Name: "Grafana Labs",
-								URL:  "https://grafana.com",
-							},
-							Logos: plugins.Logos{
-								Small: "public/img/icn-datasource.svg",
-								Large: "public/img/icn-datasource.svg",
-							},
-							Description: "Test",
-						},
-						Dependencies: plugins.Dependencies{
-							GrafanaVersion: "*",
-							Plugins:        []plugins.Dependency{},
-						},
-						Backend: true,
-						State:   plugins.ReleaseStateAlpha,
-					},
-					Class:     plugins.ClassExternal,
-					Module:    "public/plugins/test-datasource/module.js",
-					BaseURL:   "public/plugins/test-datasource",
-					FS:        mustNewStaticFSForTests(t, filepath.Join(parentDir, "testdata/unsigned-datasource/plugin")),
-					Signature: plugins.SignatureStatusUnsigned,
-				},
-			},
-		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {