diff --git a/packages/grafana-ui/src/themes/GlobalStyles/GlobalStyles.tsx b/packages/grafana-ui/src/themes/GlobalStyles/GlobalStyles.tsx index ad4be373aca..c0021ba103b 100644 --- a/packages/grafana-ui/src/themes/GlobalStyles/GlobalStyles.tsx +++ b/packages/grafana-ui/src/themes/GlobalStyles/GlobalStyles.tsx @@ -24,14 +24,9 @@ import { getSlateStyles } from './slate'; import { getUplotStyles } from './uPlot'; import { getUtilityClassStyles } from './utilityClasses'; -interface GlobalStylesProps { - isExtensionSidebarOpen?: boolean; -} - /** @internal */ -export function GlobalStyles(props: GlobalStylesProps) { +export function GlobalStyles() { const theme = useTheme2(); - const { isExtensionSidebarOpen } = props; return ( { - +
diff --git a/public/app/core/components/AppChrome/ExtensionSidebar/ExtensionSidebar.tsx b/public/app/core/components/AppChrome/ExtensionSidebar/ExtensionSidebar.tsx index 11ab8b354f0..1b632bdfcbf 100644 --- a/public/app/core/components/AppChrome/ExtensionSidebar/ExtensionSidebar.tsx +++ b/public/app/core/components/AppChrome/ExtensionSidebar/ExtensionSidebar.tsx @@ -1,4 +1,5 @@ import { css } from '@emotion/css'; +import { css as cssReact, Global } from '@emotion/react'; import { GrafanaTheme2, PluginExtensionPoints } from '@grafana/data'; import { usePluginComponents } from '@grafana/runtime'; @@ -41,6 +42,11 @@ export function ExtensionSidebar() { return (
+ {/* When the sidebar is open, we don't want the body to scroll */} + {/* Need type assertion here due to the use of !important */} + {/* see https://github.com/frenic/csstype/issues/114#issuecomment-697201978 */} + {/* eslint-disable-next-line @typescript-eslint/consistent-type-assertions */} +
diff --git a/public/app/core/components/AppChrome/ExtensionSidebar/GlobalStylesWrapper.tsx b/public/app/core/components/AppChrome/ExtensionSidebar/GlobalStylesWrapper.tsx deleted file mode 100644 index ae2d8a24266..00000000000 --- a/public/app/core/components/AppChrome/ExtensionSidebar/GlobalStylesWrapper.tsx +++ /dev/null @@ -1,13 +0,0 @@ -import { GlobalStyles } from '@grafana/ui'; - -import { useExtensionSidebarContext } from './ExtensionSidebarProvider'; - -/** - * This component is used to wrap the GlobalStyles component and pass the isExtensionSidebarOpen prop to it. - * Since GlobalStyles is imported from @grafana/ui, we need to wrap it in a component to use the useExtensionSidebarContext hook. - */ -export const GlobalStylesWrapper = () => { - const { isOpen } = useExtensionSidebarContext(); - - return ; -};