From 22e6d10e42013610dbe37de33e4312f14e3cbdfe Mon Sep 17 00:00:00 2001 From: "Grot (@grafanabot)" <43478413+grafanabot@users.noreply.github.com> Date: Fri, 18 Mar 2022 20:44:30 -0700 Subject: [PATCH] Updated bucket size/offeset settings; Check for negative values in bucket size (#46754) (#46756) (cherry picked from commit 576b73ed4878991e9f68d221a5eb423d9c65ff48) Co-authored-by: Adela Almasan <88068998+adela-almasan@users.noreply.github.com> --- .../grafana-data/src/transformations/transformers/histogram.ts | 2 +- public/app/plugins/panel/histogram/module.tsx | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/grafana-data/src/transformations/transformers/histogram.ts b/packages/grafana-data/src/transformations/transformers/histogram.ts index 0e8b2c1da88..5519c8354b4 100644 --- a/packages/grafana-data/src/transformations/transformers/histogram.ts +++ b/packages/grafana-data/src/transformations/transformers/histogram.ts @@ -152,7 +152,7 @@ export function buildHistogram(frames: DataFrame[], options?: HistogramTransform let bucketOffset = options?.bucketOffset ?? 0; // if bucket size is auto, try to calc from all numeric fields - if (!bucketSize) { + if (!bucketSize || bucketSize < 0) { let allValues: number[] = []; // TODO: include field configs! diff --git a/public/app/plugins/panel/histogram/module.tsx b/public/app/plugins/panel/histogram/module.tsx index 80f198aeea9..8eef08ec341 100644 --- a/public/app/plugins/panel/histogram/module.tsx +++ b/public/app/plugins/panel/histogram/module.tsx @@ -23,6 +23,7 @@ export const plugin = new PanelPlugin(HistogramP description: histogramFieldInfo.bucketSize.description, settings: { placeholder: 'Auto', + min: 0, }, defaultValue: defaultPanelOptions.bucketSize, showIf: (opts, data) => !originalDataHasHistogram(data), @@ -33,6 +34,7 @@ export const plugin = new PanelPlugin(HistogramP description: histogramFieldInfo.bucketOffset.description, settings: { placeholder: '0', + min: 0, }, defaultValue: defaultPanelOptions.bucketOffset, showIf: (opts, data) => !originalDataHasHistogram(data),