public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Playlists: convert to use reconcilers instead (#98075)

Browse Source
This commit is contained in:
Charandas
2024-12-19 19:09:31 -08:00
committed by GitHub
parent c172bbba50
commit 24bf337c56
12 changed files with 89 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/registry/apps/playlist/register.go
+1 -1
View File
@@ -41,7 +41,7 @@ func RegisterApp(
LegacyStorageGetter: provider.legacyStorageGetter,
ManagedKinds: playlistapp.GetKinds(),
CustomConfig: any(&playlistapp.PlaylistConfig{
EnableWatchers: features.IsEnabledGlobally(featuremgmt.FlagPlaylistsWatcher),
EnableReconcilers: features.IsEnabledGlobally(featuremgmt.FlagPlaylistsReconciler),
}),
}
provider.Provider = simple.NewAppProvider(apis.LocalManifest(), appCfg, playlistapp.New)
pkg/services/featuremgmt/registry.go
+2 -2
View File
@@ -1578,8 +1578,8 @@ var (
Expression: "true", // enabled by default
},
{
Name: "playlistsWatcher",
Description: "Enables experimental watcher for playlists",
Name: "playlistsReconciler",
Description: "Enables experimental reconciler for playlists",
Stage: FeatureStageExperimental,
Owner: grafanaAppPlatformSquad,
RequiresRestart: true,
pkg/services/featuremgmt/toggles_gen.csv
+1 -1
View File
@@ -209,7 +209,7 @@ prometheusUsesCombobox,experimental,@grafana/observability-metrics,false,false,f
userStorageAPI,experimental,@grafana/plugins-platform-backend,false,false,false
azureMonitorDisableLogLimit,GA,@grafana/partner-datasources,false,false,false
preinstallAutoUpdate,GA,@grafana/plugins-platform-backend,false,false,false
playlistsWatcher,experimental,@grafana/grafana-app-platform-squad,false,true,false
playlistsReconciler,experimental,@grafana/grafana-app-platform-squad,false,true,false
passwordlessMagicLinkAuthentication,experimental,@grafana/identity-access-team,false,false,false
exploreMetricsRelatedLogs,experimental,@grafana/observability-metrics,false,false,true
prometheusSpecialCharsInLabelValues,experimental,@grafana/observability-metrics,false,false,true
1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
209 userStorageAPI experimental @grafana/plugins-platform-backend false false false
210 azureMonitorDisableLogLimit GA @grafana/partner-datasources false false false
211 preinstallAutoUpdate GA @grafana/plugins-platform-backend false false false
212 playlistsWatcher playlistsReconciler experimental @grafana/grafana-app-platform-squad false true false
213 passwordlessMagicLinkAuthentication experimental @grafana/identity-access-team false false false
214 exploreMetricsRelatedLogs experimental @grafana/observability-metrics false false true
215 prometheusSpecialCharsInLabelValues experimental @grafana/observability-metrics false false true
pkg/services/featuremgmt/toggles_gen.go
+3 -3
View File
@@ -847,9 +847,9 @@ const (
// Enables automatic updates for pre-installed plugins
FlagPreinstallAutoUpdate = "preinstallAutoUpdate"
// FlagPlaylistsWatcher
// Enables experimental watcher for playlists
FlagPlaylistsWatcher = "playlistsWatcher"
// FlagPlaylistsReconciler
// Enables experimental reconciler for playlists
FlagPlaylistsReconciler = "playlistsReconciler"
// FlagPasswordlessMagicLinkAuthentication
// Enable passwordless login via magic link authentication
pkg/services/featuremgmt/toggles_gen.json
+8 -4
View File
@@ -2670,12 +2670,16 @@
},
{
"metadata": {
"name": "playlistsWatcher",
"resourceVersion": "1730462910506",
"creationTimestamp": "2024-11-01T12:08:30Z"
"name": "playlistsReconciler",
"resourceVersion": "1734463170112",
"creationTimestamp": "2024-11-01T12:08:30Z",
"deletionTimestamp": "2024-12-19T19:17:00Z",
"annotations": {
"grafana.app/updatedTimestamp": "2024-12-17 19:19:30.112629 +0000 UTC"
}
},
"spec": {
"description": "Enables experimental watcher for playlists",
"description": "Enables experimental reconciler for playlists",
"stage": "experimental",
"codeowner": "@grafana/grafana-app-platform-squad",
"requiresRestart": true