Auth: Remove Email Lookup from oauth integrations 9.4 (#896)

backport https://github.com/grafana/grafana-private-mirror/pull/894 to 9.4.x

pkg/api/login_oauth.go

@@ -314,16 +314,17 @@ func (hs *HTTPServer) SyncUser(
 	connect social.SocialConnector,
 ) (*user.User, error) {
 	oauthLogger.Debug("Syncing Grafana user with corresponding OAuth profile")
+	lookupParams := loginservice.UserLookupParams{}
+	if hs.Cfg.OAuthAllowInsecureEmailLookup {
+		lookupParams.Email = &extUser.Email
+	}
+
 	// add/update user in Grafana
 	cmd := &loginservice.UpsertUserCommand{
-		ReqContext:    ctx,
+		ReqContext:       ctx,
-		ExternalUser:  extUser,
+		ExternalUser:     extUser,
-		SignupAllowed: connect.IsSignupAllowed(),
+		SignupAllowed:    connect.IsSignupAllowed(),
-		UserLookupParams: loginservice.UserLookupParams{
+		UserLookupParams: lookupParams,
-			Email:  &extUser.Email,
-			UserID: nil,
-			Login:  nil,
-		},
 	}
 
 	if err := hs.Login.UpsertUser(ctx.Req.Context(), cmd); err != nil {

pkg/setting/setting.go

@@ -326,7 +326,8 @@ type Cfg struct {
 	AuthProxySyncTTL          int
 
 	// OAuth
-	OAuthCookieMaxAge int
+	OAuthCookieMaxAge             int
+	OAuthAllowInsecureEmailLookup bool
 
 	// JWT Auth
 	JWTAuthEnabled                 bool
@@ -1457,6 +1458,8 @@ func readAuthSettings(iniFile *ini.File, cfg *Cfg) (err error) {
 		return err
 	}
 
+	cfg.OAuthAllowInsecureEmailLookup = auth.Key("oauth_allow_insecure_email_lookup").MustBool(false)
+
 	const defaultMaxLifetime = "30d"
 	maxLifetimeDurationVal := valueAsString(auth, "login_maximum_lifetime_duration", defaultMaxLifetime)
 	cfg.LoginMaxLifetime, err = gtime.ParseDuration(maxLifetimeDurationVal)