sql: extract frontend code into separate package (#81109)

* sql: extract frontend code into separate package * updated package version
2024-01-26 11:38:29 +01:00
parent 2febbec758
commit 29e8a355cb
87 changed files with 187 additions and 104 deletions
@@ -0,0 +1,116 @@
+import { render, waitFor } from '@testing-library/react';
+import React from 'react';
+
+import { config } from '@grafana/runtime';
+
+import { SQLExpression } from '../types';
+import { makeVariable } from '../utils/testHelpers';
+
+import { DatasetSelector } from './DatasetSelector';
+import { buildMockDatasetSelectorProps, buildMockTableSelectorProps } from './SqlComponents.testHelpers';
+import { TableSelector } from './TableSelector';
+import { removeQuotesForMultiVariables } from './visual-query-builder/SQLWhereRow';
+
+beforeEach(() => {
+  config.featureToggles.sqlDatasourceDatabaseSelection = true;
+});
+
+afterEach(() => {
+  config.featureToggles.sqlDatasourceDatabaseSelection = false;
+});
+
+describe('DatasetSelector', () => {
+  it('should only query the database when needed', async () => {
+    const mockProps = buildMockDatasetSelectorProps();
+    render(<DatasetSelector {...mockProps} />);
+
+    await waitFor(() => {
+      expect(mockProps.db.datasets).toHaveBeenCalled();
+    });
+  });
+
+  it('should not query the database if Postgres instance, and no preconfigured database', async () => {
+    const mockProps = buildMockDatasetSelectorProps({ dialect: 'postgres' });
+    render(<DatasetSelector {...mockProps} />);
+
+    await waitFor(() => {
+      expect(mockProps.db.datasets).not.toHaveBeenCalled();
+    });
+  });
+
+  it('should not query the database if preconfigured', async () => {
+    const mockProps = buildMockDatasetSelectorProps({ preconfiguredDataset: 'database 1' });
+    render(<DatasetSelector {...mockProps} />);
+
+    await waitFor(() => {
+      expect(mockProps.db.datasets).not.toHaveBeenCalled();
+    });
+  });
+});
+
+describe('TableSelector', () => {
+  it('should only query the database when needed', async () => {
+    const mockProps = buildMockTableSelectorProps({ dataset: 'database 1' });
+    render(<TableSelector {...mockProps} />);
+
+    await waitFor(() => {
+      expect(mockProps.db.tables).toHaveBeenCalled();
+    });
+  });
+
+  it('should not query the database if no dataset is passed as a prop', async () => {
+    const mockProps = buildMockTableSelectorProps();
+    render(<TableSelector {...mockProps} />);
+
+    await waitFor(() => {
+      expect(mockProps.db.tables).not.toHaveBeenCalled();
+    });
+  });
+});
+
+describe('SQLWhereRow', () => {
+  it('should remove quotes in a where clause including multi-value variable', () => {
+    const exp: SQLExpression = {
+      whereString: "hostname IN ('${multiHost}')",
+    };
+
+    const multiVar = makeVariable('multiVar', 'multiHost', { multi: true });
+    const nonMultiVar = makeVariable('nonMultiVar', 'host', { multi: false });
+
+    const variables = [multiVar, nonMultiVar];
+
+    removeQuotesForMultiVariables(exp, variables);
+
+    expect(exp.whereString).toBe('hostname IN (${multiHost})');
+  });
+
+  it('should not remove quotes in a where clause including a non-multi variable', () => {
+    const exp: SQLExpression = {
+      whereString: "hostname IN ('${host}')",
+    };
+
+    const multiVar = makeVariable('multiVar', 'multiHost', { multi: true });
+    const nonMultiVar = makeVariable('nonMultiVar', 'host', { multi: false });
+
+    const variables = [multiVar, nonMultiVar];
+
+    removeQuotesForMultiVariables(exp, variables);
+
+    expect(exp.whereString).toBe("hostname IN ('${host}')");
+  });
+
+  it('should not remove quotes in a where clause not including any known variables', () => {
+    const exp: SQLExpression = {
+      whereString: "hostname IN ('${nonMultiHost}')",
+    };
+
+    const multiVar = makeVariable('multiVar', 'multiHost', { multi: true });
+    const nonMultiVar = makeVariable('nonMultiVar', 'host', { multi: false });
+
+    const variables = [multiVar, nonMultiVar];
+
+    removeQuotesForMultiVariables(exp, variables);
+
+    expect(exp.whereString).toBe("hostname IN ('${nonMultiHost}')");
+  });
+});