diff --git a/packages/grafana-prometheus/src/components/metrics-browser/MetricSelector.tsx b/packages/grafana-prometheus/src/components/metrics-browser/MetricSelector.tsx index 86f62480208..ec140ec183e 100644 --- a/packages/grafana-prometheus/src/components/metrics-browser/MetricSelector.tsx +++ b/packages/grafana-prometheus/src/components/metrics-browser/MetricSelector.tsx @@ -1,5 +1,5 @@ import { useMemo, useState } from 'react'; -import { FixedSizeList } from 'react-window'; +import { List } from 'react-window'; import { selectors } from '@grafana/e2e-selectors'; import { Trans, t } from '@grafana/i18n'; @@ -65,15 +65,12 @@ export function MetricSelector() { className={styles.valueListWrapper} data-testid={selectors.components.DataSource.Prometheus.queryEditor.code.metricsBrowser.metricList} > - filteredMetrics[i].name} - width={300} + - {({ index, style }) => { + rowComponent={({ index, style }) => { const metric = filteredMetrics[index]; return (
@@ -92,7 +89,11 @@ export function MetricSelector() {
); }} -
+ style={{ + height: Math.min(450, filteredMetrics.length * LIST_ITEM_SIZE), + width: 300, + }} + /> diff --git a/packages/grafana-prometheus/src/components/metrics-browser/ValueSelector.tsx b/packages/grafana-prometheus/src/components/metrics-browser/ValueSelector.tsx index e0a26f2e8e4..aa08f4e2e4b 100644 --- a/packages/grafana-prometheus/src/components/metrics-browser/ValueSelector.tsx +++ b/packages/grafana-prometheus/src/components/metrics-browser/ValueSelector.tsx @@ -1,5 +1,5 @@ import { useEffect, useState } from 'react'; -import { FixedSizeList } from 'react-window'; +import { List } from 'react-window'; import { selectors } from '@grafana/e2e-selectors'; import { t, Trans } from '@grafana/i18n'; @@ -78,15 +78,16 @@ export function ValueSelector() {
- lv[i]} - width={200} + - {({ index, style }) => { + rowComponent={({ index, style }) => { const value = lv[index]; const isSelected = selectedLabelValues[lk]?.includes(value); return ( @@ -101,7 +102,7 @@ export function ValueSelector() { ); }} - + /> ); })}