Service Accounts: Display name to ID (#46258)

* ServiceAccounts: modernize SA creation interface

* ServiceAccounts: improve service account ID generation

* ServiceAccounts: remove unused method

* ServiceAccounts: Make SA ID display name dependent

* ServiceAccounts: Add tests for Service Account creation

* trim trailing whitespace

* Update pkg/services/serviceaccounts/api/api.go

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>

* Update pkg/services/serviceaccounts/api/api.go

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>

pkg/services/serviceaccounts/database/database_test.go

@@ -8,9 +8,33 @@ import (
 	"github.com/grafana/grafana/pkg/services/serviceaccounts"
 	"github.com/grafana/grafana/pkg/services/serviceaccounts/tests"
 	"github.com/grafana/grafana/pkg/services/sqlstore"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
+func TestStore_CreateServiceAccount(t *testing.T) {
+	sqlStore, store := setupTestDatabase(t)
+	t.Run("create service account", func(t *testing.T) {
+		saDTO, err := store.CreateServiceAccount(context.Background(), 1, "new Service Account")
+		require.NoError(t, err)
+		assert.Equal(t, "sa-new-service-account", saDTO.Login)
+		assert.Equal(t, "new Service Account", saDTO.Name)
+		assert.Equal(t, 0, int(saDTO.Tokens))
+
+		query := models.GetUserByIdQuery{Id: saDTO.Id}
+		err = sqlStore.GetUserById(context.Background(), &query)
+		retrieved := query.Result
+		require.NoError(t, err)
+		assert.Equal(t, "sa-new-service-account", retrieved.Login)
+		assert.Equal(t, "new Service Account", retrieved.Name)
+		assert.Equal(t, "sa-new-service-account", retrieved.Email)
+		assert.Equal(t, "", retrieved.Password)
+		assert.Equal(t, 1, int(retrieved.OrgId))
+		assert.Len(t, retrieved.Salt, 10)
+		assert.Equal(t, true, retrieved.IsServiceAccount)
+	})
+}
+
 func TestStore_DeleteServiceAccount(t *testing.T) {
 	cases := []struct {
 		desc        string