From 2af79535bce3c6d9504c3ed6c5754c5bb57b4808 Mon Sep 17 00:00:00 2001 From: Hamas Shafiq Date: Tue, 10 Jan 2023 14:23:00 +0000 Subject: [PATCH] Chore: Fix flaky test in `SpanGraph/index.test.tsx` (#61009) --- .../src/TracePageHeader/SpanGraph/TickLabels.test.tsx | 7 +++++++ .../src/TracePageHeader/SpanGraph/index.test.tsx | 10 ---------- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/TickLabels.test.tsx b/packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/TickLabels.test.tsx index 3c71a067968..1369288e204 100644 --- a/packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/TickLabels.test.tsx +++ b/packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/TickLabels.test.tsx @@ -50,4 +50,11 @@ describe('', () => { expect(tick).toHaveStyle(`left: ${pos};`); }); }); + it('shows the correct value above each tick', () => { + expect(screen.getByText('0μs')).toBeTruthy(); + expect(screen.getByText('1.25ms')).toBeTruthy(); + expect(screen.getByText('2.5ms')).toBeTruthy(); + expect(screen.getByText('3.75ms')).toBeTruthy(); + expect(screen.getByText('5ms')).toBeTruthy(); + }); }); diff --git a/packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/index.test.tsx b/packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/index.test.tsx index a1d45aa2454..3bff839ee1c 100644 --- a/packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/index.test.tsx +++ b/packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/index.test.tsx @@ -19,8 +19,6 @@ import traceGenerator from '../../demo/trace-generators'; import transformTraceData from '../../model/transform-trace-data'; import { polyfill as polyfillAnimationFrame } from '../../utils/test/requestAnimationFrame'; -import TickLabels from './TickLabels'; - import SpanGraph, { SpanGraphProps, TIMELINE_TICK_INTERVAL } from './index'; describe('', () => { @@ -60,12 +58,4 @@ describe('', () => { const tickLabelsDiv = screen.getByTestId('TickLabels'); expect(getAllByTestId(tickLabelsDiv, 'tick').length).toBe(TIMELINE_TICK_INTERVAL + 1); }); - - it('renders with the correct value next to each tick', () => { - render(); - expect(screen.getByText(/0.2/)).toBeTruthy(); - expect(screen.getByText(/0.4/)).toBeTruthy(); - expect(screen.getByText(/0.6/)).toBeTruthy(); - expect(screen.getByText(/0.8/)).toBeTruthy(); - }); });