From 2b15fa0492a556ecb1c4149f34bc83906874d0cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Roberto=20Jim=C3=A9nez=20S=C3=A1nchez?= Date: Thu, 7 Aug 2025 12:00:31 +0200 Subject: [PATCH] Provisioning: Fix missing ref in staging options (#109311) Fix missing ref in staging options --- pkg/registry/apis/provisioning/jobs/delete/worker.go | 1 + pkg/registry/apis/provisioning/jobs/delete/worker_test.go | 1 + pkg/registry/apis/provisioning/jobs/move/worker.go | 1 + pkg/registry/apis/provisioning/jobs/move/worker_test.go | 2 +- 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/registry/apis/provisioning/jobs/delete/worker.go b/pkg/registry/apis/provisioning/jobs/delete/worker.go index 63db00ef224..3b82d51a8d5 100644 --- a/pkg/registry/apis/provisioning/jobs/delete/worker.go +++ b/pkg/registry/apis/provisioning/jobs/delete/worker.go @@ -70,6 +70,7 @@ func (w *Worker) Process(ctx context.Context, repo repository.Repository, job pr CommitOnlyOnceMessage: msg, PushOnWrites: false, Timeout: 10 * time.Minute, + Ref: opts.Ref, } err := w.wrapFn(ctx, repo, stageOptions, fn) diff --git a/pkg/registry/apis/provisioning/jobs/delete/worker_test.go b/pkg/registry/apis/provisioning/jobs/delete/worker_test.go index 7f2fa3c22bb..1da3656f6ce 100644 --- a/pkg/registry/apis/provisioning/jobs/delete/worker_test.go +++ b/pkg/registry/apis/provisioning/jobs/delete/worker_test.go @@ -164,6 +164,7 @@ func TestDeleteWorker_ProcessDeleteFilesSuccess(t *testing.T) { return !opts.PushOnWrites && opts.Timeout == 10*time.Minute && opts.Mode == repository.StageModeCommitOnlyOnce && + opts.Ref == "main" && opts.CommitOnlyOnceMessage == "Delete from Grafana "+job.Name }), mock.Anything).Return(func(ctx context.Context, repo repository.Repository, stageOptions repository.StageOptions, fn func(repository.Repository, bool) error) error { return fn(mockRepo, false) diff --git a/pkg/registry/apis/provisioning/jobs/move/worker.go b/pkg/registry/apis/provisioning/jobs/move/worker.go index b2ff1912bd5..194c85cccb0 100644 --- a/pkg/registry/apis/provisioning/jobs/move/worker.go +++ b/pkg/registry/apis/provisioning/jobs/move/worker.go @@ -81,6 +81,7 @@ func (w *Worker) Process(ctx context.Context, repo repository.Repository, job pr CommitOnlyOnceMessage: msg, PushOnWrites: false, Timeout: 10 * time.Minute, + Ref: opts.Ref, } err := w.wrapFn(ctx, repo, stageOptions, fn) diff --git a/pkg/registry/apis/provisioning/jobs/move/worker_test.go b/pkg/registry/apis/provisioning/jobs/move/worker_test.go index c398cedc830..c2e57a3552b 100644 --- a/pkg/registry/apis/provisioning/jobs/move/worker_test.go +++ b/pkg/registry/apis/provisioning/jobs/move/worker_test.go @@ -202,7 +202,7 @@ func TestMoveWorker_ProcessMoveFilesSuccess(t *testing.T) { mockWrapFn.On("Execute", mock.Anything, mockRepo, mock.MatchedBy(func(opts repository.StageOptions) bool { return !opts.PushOnWrites && opts.Timeout == 10*time.Minute && opts.Mode == repository.StageModeCommitOnlyOnce && - opts.CommitOnlyOnceMessage != "" + opts.CommitOnlyOnceMessage != "" && opts.Ref == "main" }), mock.Anything).Return(func(ctx context.Context, repo repository.Repository, stageOptions repository.StageOptions, fn func(repository.Repository, bool) error) error { return fn(mockRepo, false) })